Date: Wed, 08 Mar 2006 08:22:40 -0800 From: Colin Percival <cperciva@freebsd.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: arch@freebsd.org Subject: Re: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c Message-ID: <440F04D0.8050605@freebsd.org> In-Reply-To: <20060308.090211.97454770.imp@bsdimp.com> References: <20060307.233728.42821161.imp@bsdimp.com> <20060308092207.GB679@turion.vk2pj.dyndns.org> <440EF0B0.1010203@samsco.org> <20060308.090211.97454770.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
M. Warner Losh wrote: > : Peter Jeremy wrote: > : > On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote: > : >> Log: > : >> Remove leading __ from __(inline|const|signed|volatile). They are > : >> obsolete. This should reduce diffs to NetBSD as well. > : > > : > Also, any diff reduction with NetBSD is probably outweighed by > : > the diff increase with other FreeBSD branches. > : > > : > Maybe this should be treated like whitespace cleanup - something to > : > do if you're going to be doing something non-trivial in the source > : > file. (There are probably other cleanups in the same category). > > Would merging these to RELENG_6 help any? RELENG_5 is dead after this > release anyway... FYI, cosmetic churn causes headaches for the Security Team: It means that we have to produce lots of different patches for an issue rather than just one patch. (And inevitably we don't notice that the patches won't apply correctly until we're about to send out the advisory...) Admittedly, this isn't a major concern, but it is certainly one reason to make cosmetic changes at the same time as substantive changes rather than separately. Colin Percival
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?440F04D0.8050605>