Date: Tue, 28 May 2019 07:26:23 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238183] cam/scsi/scsi_sa.c: warnings issued by static analysis Message-ID: <bug-238183-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238183 Bug ID: 238183 Summary: cam/scsi/scsi_sa.c: warnings issued by static analysis Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: danfe@FreeBSD.org PVS Studio produces lots of warnings over /usr/src/sys/cam/scsi/scsi_sa.c, but most of them are too noisy and out of scope right now. Three of them, however, look more sensible and probably worth taking a closer look: cam/scsi/scsi_sa.c:3216:1: warning: V547 Expression 'softc->last_media_blksize == 0' is always false. cam/scsi/scsi_sa.c:3550:1: warning: V560 A part of conditional expression is always false: (stream_valid == 0). cam/scsi/scsi_sa.c:4416:1: warning: V519 The 'error' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 4414, 4416. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238183-227>