Date: Mon, 17 Sep 2001 09:57:18 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Mike Barcroft <mike@FreeBSD.org>, Alexey Zelkin <phantom@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib strfmon.c Message-ID: <20010917095717.B48120@sunbay.com> In-Reply-To: <20010914185140.A32495@coffee.q9media.com>; from mike@FreeBSD.org on Fri, Sep 14, 2001 at 06:51:40PM -0400 References: <200109060926.f869QS033887@freefall.freebsd.org> <20010906155654.I18362@sunbay.com> <20010914185140.A32495@coffee.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 14, 2001 at 06:51:40PM -0400, Mike Barcroft wrote:
> Ruslan Ermilov <ru@FreeBSD.org> writes:
> > On Thu, Sep 06, 2001 at 02:26:28AM -0700, Alexey Zelkin wrote:
> > > phantom 2001/09/06 02:26:28 PDT
> > >
> > > Modified files:
> > > lib/libc/stdlib strfmon.c
> > > Log:
> > > correctly wrap macros with { }
> > >
> > > Revision Changes Path
> > > 1.2 +4 -3 src/lib/libc/stdlib/strfmon.c
> > >
> > Nope, this is incorrect. You didn't read the whole thread.
> > The correct fix it is to wrap macros in ``{ } while(0)'':
> >
> > #define PRINT(CH) do { \
> > if (dst >= s + maxsize) \
> > goto e2big_error; \
> > *dst++ = CH; \
> > } while(0)
> >
> > See style(9) for more details.
>
> Alexey,
> Is there a reason you haven't fixed this yet?
>
Alexey told me (in a private mail) he will be fixing this and
these in his next cleanup round.
Cheers,
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010917095717.B48120>