Date: Mon, 30 Aug 2021 11:24:24 -0400 From: Ed Maste <emaste@freebsd.org> To: Mitchell Horne <mhorne@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 4d0dc60f1401 - main - xinstall: fix invocation of llvm-strip Message-ID: <CAPyFy2B4NVrGgrp2JuGdN_JKFN22sH7qHBPxZK0GxmdDNEq%2BGA@mail.gmail.com> In-Reply-To: <202108301457.17UEvCRv008780@gitrepo.freebsd.org> References: <202108301457.17UEvCRv008780@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 30 Aug 2021 at 10:57, Mitchell Horne <mhorne@freebsd.org> wrote: > > The branch main has been updated by mhorne: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4d0dc60f14019eab08f6d9dc656c9f9f1ebdde02 > > commit 4d0dc60f14019eab08f6d9dc656c9f9f1ebdde02 > Author: Mitchell Horne <mhorne@FreeBSD.org> > AuthorDate: 2021-06-02 15:00:56 +0000 > Commit: Mitchell Horne <mhorne@FreeBSD.org> > CommitDate: 2021-08-30 14:56:10 +0000 > > xinstall: fix invocation of llvm-strip > > When executing strip(1), '--' is passed as an argument to explicitly > terminate the getopt(3) loop. The option parsing in llvm-strip doesn't > support this however, so setting XSTRIPBIN=llvm-strip results in an > unsupported argument error. llvm-strip(1) is otherwise > commandline-compatible with FreeBSD's strip(1), so just use the > documented argument format that is common to both. GNU strip also handles --, so ideally we'd have llvm-strip also accept it. Given plans to switch to the LLVM version of various binutils (D31060) we should aim for as complete command-line compatibility as possible. I've added a note to this effect in D31060.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2B4NVrGgrp2JuGdN_JKFN22sH7qHBPxZK0GxmdDNEq%2BGA>