Date: Thu, 10 Nov 2005 10:40:15 +0000 (UTC) From: "Ralf S. Engelschall" <rse@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/etc/rc.d pf Message-ID: <200511101040.jAAAeFdu068388@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rse 2005-11-10 10:40:15 UTC
FreeBSD src repository
Modified files:
etc/rc.d pf
Log:
Backout r1.11...
> > There is no need to explicitly add "status" to $extra_commands in
> > the /etc/rc.d/pf script as it is implicitly added by /etc/rc.subr's
> > run_rc_command() because of the existing $pf_program.
> >
> > Submitted by: Christoph Schug <chris@schug.net>
...because as yar@ points out: "[...] you were relying on evil
side-effects of the variable being named *_program. hose side-effect
have been eliminated since rc.subr rev. 1.42. [...] The point is that
the default "status" method is for rc.d scripts that handle startup and
shutdown of conventional daemons, and not for custom tasks like the pf
case."
The change is still valid in RELENG_6 (and still doesn't have to be
backed out) as long as rc.subr:r1.42 is not MFC'ed to RELENG_6, too.
Revision Changes Path
1.12 +1 -1 src/etc/rc.d/pf
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511101040.jAAAeFdu068388>