Date: Thu, 19 Oct 2017 20:00:51 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org> Cc: Shane <FreeBSD@ShaneWare.Biz>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r452419 - in head/graphics: . ptex ptex/files Message-ID: <fuaf-c90s-wny@FreeBSD.org> In-Reply-To: <201710191310.v9JDAmdQ047764@repo.freebsd.org> (Steve Wills's message of "Thu, 19 Oct 2017 13:10:48 %2B0000 (UTC)") References: <201710191310.v9JDAmdQ047764@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Steve Wills <swills@FreeBSD.org> writes: > +PORTNAME= ptex [...] > +GH_PROJECT= ptex One of these is redundant. > +PORTVERSION= 2.1.28 > +GH_TAGNAME= v${PORTVERSION} Use DISTVERSIONPREFIX. https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex3 > +DOCS_BUILD_DEPENDS= doxygen:devel/doxygen Maybe rename to DOXYGEN, so users can disable it globally via OPTIONS_UNSET. DOCS is enabled by default, so you may want to enable DOXYGEN as well. https://lists.freebsd.org/pipermail/freebsd-ports/2015-March/098258.html https://svnweb.freebsd.org/changeset/ports/428947 https://svnweb.freebsd.org/changeset/ports/429005 https://svnweb.freebsd.org/changeset/ports/429007 https://svnweb.freebsd.org/changeset/ports/429087 https://svnweb.freebsd.org/changeset/ports/429088 https://svnweb.freebsd.org/changeset/ports/429089 https://svnweb.freebsd.org/changeset/ports/429090 https://svnweb.freebsd.org/changeset/ports/429091 https://svnweb.freebsd.org/changeset/ports/429092 https://svnweb.freebsd.org/changeset/ports/429093 https://svnweb.freebsd.org/changeset/ports/429094 https://svnweb.freebsd.org/changeset/ports/429095 https://svnweb.freebsd.org/changeset/ports/429096 https://svnweb.freebsd.org/changeset/ports/429098 https://svnweb.freebsd.org/changeset/ports/429099 https://svnweb.freebsd.org/changeset/ports/429228 (reverts r429099) https://svnweb.freebsd.org/changeset/ports/429229 (reverts r429097) > +.include <bsd.port.options.mk> Unused line. Nothing later uses .if/.for conditionals. > ++#if !defined(__FreeBSD__) > + #include <alloca.h> > ++#endif None of BSDs have <alloca.h>, including DragonFly which is a downstream consumer of FreeBSD Ports.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fuaf-c90s-wny>