Date: Mon, 18 Sep 2017 09:07:32 -0700 From: Conrad Meyer <cem@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Conrad Meyer <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323692 - in head/sys/compat: linsysfs linux Message-ID: <CAG6CVpXA1nEXWay4ST8Skm9cEncmQ1OqH=03g2ZEbugd0B-zBw@mail.gmail.com> In-Reply-To: <7527afaa-c983-a2dd-6a1c-a20bb1d03d7a@selasky.org> References: <201709172340.v8HNeGuP016998@repo.freebsd.org> <7527afaa-c983-a2dd-6a1c-a20bb1d03d7a@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This was not introduced in this change.
On Mon, Sep 18, 2017 at 8:05 AM, Hans Petter Selasky <hps@selasky.org> wrote:
> On 09/18/17 01:40, Conrad Meyer wrote:
>>
>> device_get_children(dev, &children, &nchildren);
>> for (i = 0; i < nchildren; i++) {
>> if (children[i])
>> - linsysfs_run_bus(children[i], dir, scsi, new_path,
>> prefix);
>> + linsysfs_run_bus(children[i], dir, scsi, chardev,
>> new_path, prefix);
>> }
>> if (new_path != path)
>> free(new_path, M_TEMP);
>> + free(chardevname, M_TEMP);
>> return (1);
>
>
> 1) Return code from device_get_children() should be checked.
>
> 2) children pointer should be freed else there is a memory leak.
>
> --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXA1nEXWay4ST8Skm9cEncmQ1OqH=03g2ZEbugd0B-zBw>