Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Nov 2022 16:59:32 +0000
From:      Doug Rabson <dfr@rabson.org>
To:        Kyle Evans <kevans@freebsd.org>
Cc:        Guido Falsi <mad@madpilot.net>, freebsd-pkgbase@freebsd.org
Subject:   Re: New conflict on if_wg.h in runtime package
Message-ID:  <CACA0VUjRvsy6MCJWcFo_k-_vv0F_3kRnADmxXSaw2GRT22c0pw@mail.gmail.com>
In-Reply-To: <CACNAnaEO0Ys-YMQ6rqv7_8etWJgxBTfC7T_aLZ_zHu3vYYxqEw@mail.gmail.com>
References:  <edc66854-7f9e-9383-643a-7ffb76b60890@madpilot.net> <CACA0VUiU8zvWgiwcUs8-sg6PmcQiMGGu-1v8j0HBGQPj2_VFzA@mail.gmail.com> <c1e4cdb7-51b0-7a6b-7ada-fd22cb8d94f7@madpilot.net> <CACA0VUhU2NjaU=tJhvXqcrO0%2BBcgSA_cGrkeYTy3upKzucw1uQ@mail.gmail.com> <CACNAnaHW%2Bn2ZjZZsQmknxSAXcp4a=xdsCEhR5L0fRUOw8gFwrA@mail.gmail.com> <CACA0VUhaTJQX8FjL3gc9U7U2k62vZa%2BrGtMkKm=YWoAX_oWWHA@mail.gmail.com> <CACNAnaEO0Ys-YMQ6rqv7_8etWJgxBTfC7T_aLZ_zHu3vYYxqEw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000006594f805ec7fc45a
Content-Type: text/plain; charset="UTF-8"

On Wed, 2 Nov 2022 at 16:48, Kyle Evans <kevans@freebsd.org> wrote:

> On Wed, Nov 2, 2022 at 11:35 AM Doug Rabson <dfr@rabson.org> wrote:
> >
> >
> >
> > On Wed, 2 Nov 2022 at 16:30, Kyle Evans <kevans@freebsd.org> wrote:
> >>
> >> On Wed, Nov 2, 2022 at 11:21 AM Doug Rabson <dfr@rabson.org> wrote:
> >> >
> >> >
> >> >
> >> > On Wed, 2 Nov 2022 at 16:07, Guido Falsi <mad@madpilot.net> wrote:
> >> >>
> >> >> On 02/11/22 16:32, Doug Rabson wrote:
> >> >> >
> >> >> >
> >> >> > On Wed, 2 Nov 2022 at 13:54, Guido Falsi <mad@madpilot.net
> >> >> > <mailto:mad@madpilot.net>> wrote:
> >> >> >
> >> >> >     Hi!
> >> >> >
> >> >> >     I am trying to upgrade head using packaged base and I'm
> getting this
> >> >> >     error now:
> >> >> >
> >> >> >     pkg: FreeBSD-runtime-dev-14.snap20221102095743 conflicts with
> >> >> >     FreeBSD-runtime-14.snap20221102095743 (installs files into the
> same
> >> >> >     place).  Problematic file: /usr/include/dev/wg/if_wg.h
> >> >> >
> >> >> >     Looks like for some reason if_wg.h ended up in both packages.
> >> >> >
> >> >> >     Am I doing something wrong and can I work around this or
> should this be
> >> >> >     fixed in the sources?
> >> >> >
> >> >> >
> >> >> > This seems to be a problem in pkgbase. Packages are built using the
> >> >> > metalog generated from the various install commands during the
> build -
> >> >> > if_wg.h has two entries in the metalog, one with
> >> >> > tags=package=runtime,dev and one with tags=package=runtime. Can
> you open
> >> >> > a bug on bugs.freebsd.org <http://bugs.freebsd.org>?
> >> >> >
> >> >> >
> >> >>
> >> >>
> >> >> sure!
> >> >
> >> >
> >> > I think the problem is caused by the 'copies' target in src/include
> which is where the second metalog entry happens. From my limited
> understanding, this target shouldn't create metalog entries but I'm not
> sure how to stop it.
> >> >>
> >>
> >> It's via ${INSTALL}, which uses ${INSTALLFLAGS} that includes metalog
> >> bits. The problem is we're using the global ${TAG_ARGS} for those, but
> >> that's wrong on a number of levels. All of the headers need, at a
> >> minimum, a version of ${TAG_ARGS} that has ,dev, but also a lot of
> >> these have their own *PACKAGE that they should go to instead.
> >
> > That makes sense - for if_wg.h, there is an explicit entry in the WG
> group which does get installed with ,dev.
> >
>
> I think the end-result is that we actually *only* want the entries
> from the copies (or symlinks) targets so that we preserve the final
> state, even though it's pretty much just going to be copies for most
> people. We just need to restructure those to more surgically operate
> on INCS/INCSGROUPS.
>

Is that something you have time to work on? I am very far from
understanding how this stuff works :(

--0000000000006594f805ec7fc45a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, 2 Nov 2022 at 16:48, Kyle Eva=
ns &lt;<a href=3D"mailto:kevans@freebsd.org">kevans@freebsd.org</a>&gt; wro=
te:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px =
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(2=
04,204,204);padding-left:1ex">On Wed, Nov 2, 2022 at 11:35 AM Doug Rabson &=
lt;<a href=3D"mailto:dfr@rabson.org" target=3D"_blank">dfr@rabson.org</a>&g=
t; wrote:<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt; On Wed, 2 Nov 2022 at 16:30, Kyle Evans &lt;<a href=3D"mailto:kevans@f=
reebsd.org" target=3D"_blank">kevans@freebsd.org</a>&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt; On Wed, Nov 2, 2022 at 11:21 AM Doug Rabson &lt;<a href=3D"mailto:=
dfr@rabson.org" target=3D"_blank">dfr@rabson.org</a>&gt; wrote:<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; On Wed, 2 Nov 2022 at 16:07, Guido Falsi &lt;<a href=3D"mailt=
o:mad@madpilot.net" target=3D"_blank">mad@madpilot.net</a>&gt; wrote:<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; On 02/11/22 16:32, Doug Rabson wrote:<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt; On Wed, 2 Nov 2022 at 13:54, Guido Falsi &lt;<a href=
=3D"mailto:mad@madpilot.net" target=3D"_blank">mad@madpilot.net</a><br>
&gt;&gt; &gt;&gt; &gt; &lt;mailto:<a href=3D"mailto:mad@madpilot.net" targe=
t=3D"_blank">mad@madpilot.net</a>&gt;&gt; wrote:<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0Hi!<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0I am trying to upgrade head using=
 packaged base and I&#39;m getting this<br>
&gt;&gt; &gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0error now:<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0pkg: FreeBSD-runtime-dev-14.snap2=
0221102095743 conflicts with<br>
&gt;&gt; &gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0FreeBSD-runtime-14.snap2022110209=
5743 (installs files into the same<br>
&gt;&gt; &gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0place).=C2=A0 Problematic file: /=
usr/include/dev/wg/if_wg.h<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0Looks like for some reason if_wg.=
h ended up in both packages.<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0Am I doing something wrong and ca=
n I work around this or should this be<br>
&gt;&gt; &gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0fixed in the sources?<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt; This seems to be a problem in pkgbase. Packages are =
built using the<br>
&gt;&gt; &gt;&gt; &gt; metalog generated from the various install commands =
during the build -<br>
&gt;&gt; &gt;&gt; &gt; if_wg.h has two entries in the metalog, one with<br>
&gt;&gt; &gt;&gt; &gt; tags=3Dpackage=3Druntime,dev and one with tags=3Dpac=
kage=3Druntime. Can you open<br>
&gt;&gt; &gt;&gt; &gt; a bug on <a href=3D"http://bugs.freebsd.org" rel=3D"=
noreferrer" target=3D"_blank">bugs.freebsd.org</a> &lt;<a href=3D"http://bu=
gs.freebsd.org" rel=3D"noreferrer" target=3D"_blank">http://bugs.freebsd.or=
g</a>&gt;?<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt; &gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; sure!<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; I think the problem is caused by the &#39;copies&#39; target =
in src/include which is where the second metalog entry happens. From my lim=
ited understanding, this target shouldn&#39;t create metalog entries but I&=
#39;m not sure how to stop it.<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; It&#39;s via ${INSTALL}, which uses ${INSTALLFLAGS} that includes =
metalog<br>
&gt;&gt; bits. The problem is we&#39;re using the global ${TAG_ARGS} for th=
ose, but<br>
&gt;&gt; that&#39;s wrong on a number of levels. All of the headers need, a=
t a<br>
&gt;&gt; minimum, a version of ${TAG_ARGS} that has ,dev, but also a lot of=
<br>
&gt;&gt; these have their own *PACKAGE that they should go to instead.<br>
&gt;<br>
&gt; That makes sense - for if_wg.h, there is an explicit entry in the WG g=
roup which does get installed with ,dev.<br>
&gt;<br>
<br>
I think the end-result is that we actually *only* want the entries<br>
from the copies (or symlinks) targets so that we preserve the final<br>
state, even though it&#39;s pretty much just going to be copies for most<br=
>
people. We just need to restructure those to more surgically operate<br>
on INCS/INCSGROUPS.<br></blockquote><div><br></div><div>Is that something y=
ou have time to work on? I am very far from understanding how this stuff wo=
rks :(</div><div><br></div></div></div>

--0000000000006594f805ec7fc45a--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACA0VUjRvsy6MCJWcFo_k-_vv0F_3kRnADmxXSaw2GRT22c0pw>