Date: Tue, 3 Jun 2014 10:29:39 +0900 From: Yonghyeon PYUN <pyunyh@gmail.com> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, Marcel Moolenaar <marcel@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org> Subject: Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net Message-ID: <20140603012939.GA2998@michelle.cdnetworks.com> In-Reply-To: <DA4CB2BA-A551-47A4-9E44-766FA29E2EF2@xcllnt.net> References: <201406021754.s52Hsd1B039620@svn.freebsd.org> <CAJ-VmonRqXrzrqQys_9s7-o8DFmOE_c_BZWupezm0i%2BW7E09vA@mail.gmail.com> <CAJ-VmonDJCLYWBPiz1ntFRm8aj4WQd5iHMKK0Wm3hcdjZmxghw@mail.gmail.com> <DA4CB2BA-A551-47A4-9E44-766FA29E2EF2@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 02, 2014 at 11:42:10AM -0700, Marcel Moolenaar wrote: > > On Jun 2, 2014, at 11:27 AM, Adrian Chadd <adrian@freebsd.org> wrote: > > > .. and actually, bikeshedding for a moment, would we be able to move a > > lot of these accessor methods over to inlines? Would that break the > > Juniper way of doing things? > > That would definitely break Juniper as it doesn't give a stable > ABI. > > I've suggested an approach that allows for both, but it was deemed > unnecessary. The argument being that the function call overhead is > negligible. > > We can always revisit that decision if needed... > The function call overheads shall show measurable differences on slow boxes. This change adds several function calls in driver's fast path(interrupt handler, packet statistics, checksum offloading checking and etc) and these functions would be called on every TX/RX packet. It would be great if there is a way to minimize function call overheads in fast path.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140603012939.GA2998>