Date: Sun, 3 Aug 2025 07:23:21 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8d8a745c456c - main - libutil: Drop auth_getval() Message-ID: <CAFDf7U%2Bj4i=PJ=gfdWdjGYtQYsdEJcF7Z2%2B8uahm1WLQK1b5=Q@mail.gmail.com> In-Reply-To: <202508021757.572Hv2Ox066248@gitrepo.freebsd.org> References: <202508021757.572Hv2Ox066248@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hello! Not sure if it is related but I've spoted that lang/ghc is failing on configure on main-n279255-95f8c3e1ed0c: Sat Aug 2: chmod 644 '/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/lib/package.conf.d/template-haskell-2.20.0.0.conf' '/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/bin/ghc-pkg' --global-package-db "/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/lib/package.conf.d" recache ld-elf.so.1: Shared object "libutil.so.9" not found, required by "ghc-pkg" gmake: *** [Makefile:235: update_package_db] Error 1 Thanks, Dag-Erling Smørgrav <des@freebsd.org> escreveu (sábado, 2/08/2025 à(s) 18:57): > The branch main has been updated by des: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=8d8a745c456cacf706689febee9639f5e8292fc8 > > commit 8d8a745c456cacf706689febee9639f5e8292fc8 > Author: Dag-Erling Smørgrav <des@FreeBSD.org> > AuthorDate: 2025-08-02 17:56:16 +0000 > Commit: Dag-Erling Smørgrav <des@FreeBSD.org> > CommitDate: 2025-08-02 17:56:35 +0000 > > libutil: Drop auth_getval() > > This function has been an empty stub for years; now that we're bumping > the library version, we can finally get rid of it. > > Fixes: 0c381b7f0570 > Reviewed by: kib, emaste > Differential Revision: https://reviews.freebsd.org/D51704 > --- > lib/libutil/Makefile | 2 +- > lib/libutil/Symbol.map | 1 - > lib/libutil/auth.c | 44 -------------------------------------------- > lib/libutil/libutil.h | 1 - > 4 files changed, 1 insertion(+), 47 deletions(-) > > diff --git a/lib/libutil/Makefile b/lib/libutil/Makefile > index d445bc5dec3b..12ac623aec6b 100644 > --- a/lib/libutil/Makefile > +++ b/lib/libutil/Makefile > @@ -9,7 +9,7 @@ PACKAGE= runtime > LIB= util > SHLIB_MAJOR= 10 > > -SRCS= _secure_path.c auth.c cpuset.c expand_number.c flopen.c fparseln.c > \ > +SRCS= _secure_path.c cpuset.c expand_number.c flopen.c fparseln.c \ > ftime.c getlocalbase.c gr_util.c \ > hexdump.c humanize_number.c kinfo_getfile.c \ > kinfo_getallproc.c kinfo_getproc.c kinfo_getvmmap.c \ > diff --git a/lib/libutil/Symbol.map b/lib/libutil/Symbol.map > index d4bac5b5f53e..8c8fff451cd1 100644 > --- a/lib/libutil/Symbol.map > +++ b/lib/libutil/Symbol.map > @@ -2,7 +2,6 @@ FBSD_1.8 { > _secure_path; > auth_cat; > auth_checknologin; > - auth_getval; > auth_hostok; > auth_timeok; > auth_ttyok; > diff --git a/lib/libutil/auth.c b/lib/libutil/auth.c > deleted file mode 100644 > index 3414fc8e26e7..000000000000 > --- a/lib/libutil/auth.c > +++ /dev/null > @@ -1,44 +0,0 @@ > -/*- > - * SPDX-License-Identifier: BSD-2-Clause > - * > - * Simple authentication database handling code. > - * > - * Copyright (c) 1998 > - * Jordan Hubbard. All rights reserved. > - * > - * Redistribution and use in source and binary forms, with or without > - * modification, are permitted provided that the following conditions > - * are met: > - * 1. Redistributions of source code must retain the above copyright > - * notice, this list of conditions and the following disclaimer, > - * verbatim and that no modifications are made prior to this > - * point in the file. > - * 2. Redistributions in binary form must reproduce the above copyright > - * notice, this list of conditions and the following disclaimer in the > - * documentation and/or other materials provided with the distribution. > - * > - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR > - * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR > PURPOSE > - * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR HIS PETS BE LIABLE > - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > CONSEQUENTIAL > - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS > - * OR SERVICES; LOSS OF USE, DATA, LIFE OR PROFITS; OR BUSINESS > INTERRUPTION) > - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, > STRICT > - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY > WAY > - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > - * SUCH DAMAGE. > - */ > - > -#include <sys/cdefs.h> > -#include <stdlib.h> > - > -#include <libutil.h> > - > -char * > -auth_getval(const char *name) > -{ > - > - (void)name; > - return (NULL); > -} > diff --git a/lib/libutil/libutil.h b/lib/libutil/libutil.h > index 6d36a0c291c6..d27262e44daf 100644 > --- a/lib/libutil/libutil.h > +++ b/lib/libutil/libutil.h > @@ -86,7 +86,6 @@ struct termios; > struct winsize; > > __BEGIN_DECLS > -char *auth_getval(const char *_name); > void clean_environment(const char * const *_white, > const char * const *_more_white); > int expand_number(const char *_buf, int64_t *_num); > > -- Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org [-- Attachment #2 --] <div dir="ltr"><div><div>Hello!<br><br></div>Not sure if it is related but I've spoted that lang/ghc is failing on configure on main-n279255-95f8c3e1ed0c: Sat Aug 2:<br><br>chmod 644 '/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/lib/package.conf.d/template-haskell-2.20.0.0.conf'<br>'/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/bin/ghc-pkg' --global-package-db "/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/lib/package.conf.d" recache<br>ld-elf.so.1: Shared object "libutil.so.9" not found, required by "ghc-pkg"<br>gmake: *** [Makefile:235: update_package_db] Error 1<br><br></div>Thanks,</div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Dag-Erling Smørgrav <<a href="mailto:des@freebsd.org">des@freebsd.org</a>> escreveu (sábado, 2/08/2025 à(s) 18:57):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by des:<br> <br> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=8d8a745c456cacf706689febee9639f5e8292fc8" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=8d8a745c456cacf706689febee9639f5e8292fc8</a><br>; <br> commit 8d8a745c456cacf706689febee9639f5e8292fc8<br> Author: Dag-Erling Smørgrav <des@FreeBSD.org><br> AuthorDate: 2025-08-02 17:56:16 +0000<br> Commit: Dag-Erling Smørgrav <des@FreeBSD.org><br> CommitDate: 2025-08-02 17:56:35 +0000<br> <br> libutil: Drop auth_getval()<br> <br> This function has been an empty stub for years; now that we're bumping<br> the library version, we can finally get rid of it.<br> <br> Fixes: 0c381b7f0570<br> Reviewed by: kib, emaste<br> Differential Revision: <a href="https://reviews.freebsd.org/D51704" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D51704</a><br>; ---<br> lib/libutil/Makefile | 2 +-<br> lib/libutil/Symbol.map | 1 -<br> lib/libutil/auth.c | 44 --------------------------------------------<br> lib/libutil/libutil.h | 1 -<br> 4 files changed, 1 insertion(+), 47 deletions(-)<br> <br> diff --git a/lib/libutil/Makefile b/lib/libutil/Makefile<br> index d445bc5dec3b..12ac623aec6b 100644<br> --- a/lib/libutil/Makefile<br> +++ b/lib/libutil/Makefile<br> @@ -9,7 +9,7 @@ PACKAGE= runtime<br> LIB= util<br> SHLIB_MAJOR= 10<br> <br> -SRCS= _secure_path.c auth.c cpuset.c expand_number.c flopen.c fparseln.c \<br> +SRCS= _secure_path.c cpuset.c expand_number.c flopen.c fparseln.c \<br> ftime.c getlocalbase.c gr_util.c \<br> hexdump.c humanize_number.c kinfo_getfile.c \<br> kinfo_getallproc.c kinfo_getproc.c kinfo_getvmmap.c \<br> diff --git a/lib/libutil/Symbol.map b/lib/libutil/Symbol.map<br> index d4bac5b5f53e..8c8fff451cd1 100644<br> --- a/lib/libutil/Symbol.map<br> +++ b/lib/libutil/Symbol.map<br> @@ -2,7 +2,6 @@ FBSD_1.8 {<br> _secure_path;<br> auth_cat;<br> auth_checknologin;<br> - auth_getval;<br> auth_hostok;<br> auth_timeok;<br> auth_ttyok;<br> diff --git a/lib/libutil/auth.c b/lib/libutil/auth.c<br> deleted file mode 100644<br> index 3414fc8e26e7..000000000000<br> --- a/lib/libutil/auth.c<br> +++ /dev/null<br> @@ -1,44 +0,0 @@<br> -/*-<br> - * SPDX-License-Identifier: BSD-2-Clause<br> - *<br> - * Simple authentication database handling code.<br> - *<br> - * Copyright (c) 1998<br> - * Jordan Hubbard. All rights reserved.<br> - *<br> - * Redistribution and use in source and binary forms, with or without<br> - * modification, are permitted provided that the following conditions<br> - * are met:<br> - * 1. Redistributions of source code must retain the above copyright<br> - * notice, this list of conditions and the following disclaimer,<br> - * verbatim and that no modifications are made prior to this<br> - * point in the file.<br> - * 2. Redistributions in binary form must reproduce the above copyright<br> - * notice, this list of conditions and the following disclaimer in the<br> - * documentation and/or other materials provided with the distribution.<br> - *<br> - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR<br> - * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE<br> - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE<br> - * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR HIS PETS BE LIABLE<br> - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL<br> - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS<br> - * OR SERVICES; LOSS OF USE, DATA, LIFE OR PROFITS; OR BUSINESS INTERRUPTION)<br> - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT<br> - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY<br> - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF<br> - * SUCH DAMAGE.<br> - */<br> -<br> -#include <sys/cdefs.h><br> -#include <stdlib.h><br> -<br> -#include <libutil.h><br> -<br> -char *<br> -auth_getval(const char *name)<br> -{<br> -<br> - (void)name;<br> - return (NULL);<br> -}<br> diff --git a/lib/libutil/libutil.h b/lib/libutil/libutil.h<br> index 6d36a0c291c6..d27262e44daf 100644<br> --- a/lib/libutil/libutil.h<br> +++ b/lib/libutil/libutil.h<br> @@ -86,7 +86,6 @@ struct termios;<br> struct winsize;<br> <br> __BEGIN_DECLS<br> -char *auth_getval(const char *_name);<br> void clean_environment(const char * const *_white,<br> const char * const *_more_white);<br> int expand_number(const char *_buf, int64_t *_num);<br> <br> </blockquote></div><div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><font color="#888888">Nuno Teixeira</font></div><div><div><font color="#888888"> FreeBSD UNIX: <eduardo@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br></font></div></div></div></div>;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2Bj4i=PJ=gfdWdjGYtQYsdEJcF7Z2%2B8uahm1WLQK1b5=Q>