Date: Sun, 3 Aug 2025 07:23:21 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8d8a745c456c - main - libutil: Drop auth_getval() Message-ID: <CAFDf7U%2Bj4i=PJ=gfdWdjGYtQYsdEJcF7Z2%2B8uahm1WLQK1b5=Q@mail.gmail.com> In-Reply-To: <202508021757.572Hv2Ox066248@gitrepo.freebsd.org> References: <202508021757.572Hv2Ox066248@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000c14e23063b700719 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello! Not sure if it is related but I've spoted that lang/ghc is failing on configure on main-n279255-95f8c3e1ed0c: Sat Aug 2: chmod 644 '/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/lib/packag= e.conf.d/template-haskell-2.20.0.0.conf' '/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/bin/ghc-pk= g' --global-package-db "/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/lib/packag= e.conf.d" recache ld-elf.so.1: Shared object "libutil.so.9" not found, required by "ghc-pkg" gmake: *** [Makefile:235: update_package_db] Error 1 Thanks, Dag-Erling Sm=C3=B8rgrav <des@freebsd.org> escreveu (s=C3=A1bado, 2/08/2025= =C3=A0(s) 18:57): > The branch main has been updated by des: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D8d8a745c456cacf706689febee9639f= 5e8292fc8 > > commit 8d8a745c456cacf706689febee9639f5e8292fc8 > Author: Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> > AuthorDate: 2025-08-02 17:56:16 +0000 > Commit: Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> > CommitDate: 2025-08-02 17:56:35 +0000 > > libutil: Drop auth_getval() > > This function has been an empty stub for years; now that we're bumpin= g > the library version, we can finally get rid of it. > > Fixes: 0c381b7f0570 > Reviewed by: kib, emaste > Differential Revision: https://reviews.freebsd.org/D51704 > --- > lib/libutil/Makefile | 2 +- > lib/libutil/Symbol.map | 1 - > lib/libutil/auth.c | 44 -------------------------------------------- > lib/libutil/libutil.h | 1 - > 4 files changed, 1 insertion(+), 47 deletions(-) > > diff --git a/lib/libutil/Makefile b/lib/libutil/Makefile > index d445bc5dec3b..12ac623aec6b 100644 > --- a/lib/libutil/Makefile > +++ b/lib/libutil/Makefile > @@ -9,7 +9,7 @@ PACKAGE=3D runtime > LIB=3D util > SHLIB_MAJOR=3D 10 > > -SRCS=3D _secure_path.c auth.c cpuset.c expand_number.c flopen.c fparsel= n.c > \ > +SRCS=3D _secure_path.c cpuset.c expand_number.c flopen.c fparseln.c \ > ftime.c getlocalbase.c gr_util.c \ > hexdump.c humanize_number.c kinfo_getfile.c \ > kinfo_getallproc.c kinfo_getproc.c kinfo_getvmmap.c \ > diff --git a/lib/libutil/Symbol.map b/lib/libutil/Symbol.map > index d4bac5b5f53e..8c8fff451cd1 100644 > --- a/lib/libutil/Symbol.map > +++ b/lib/libutil/Symbol.map > @@ -2,7 +2,6 @@ FBSD_1.8 { > _secure_path; > auth_cat; > auth_checknologin; > - auth_getval; > auth_hostok; > auth_timeok; > auth_ttyok; > diff --git a/lib/libutil/auth.c b/lib/libutil/auth.c > deleted file mode 100644 > index 3414fc8e26e7..000000000000 > --- a/lib/libutil/auth.c > +++ /dev/null > @@ -1,44 +0,0 @@ > -/*- > - * SPDX-License-Identifier: BSD-2-Clause > - * > - * Simple authentication database handling code. > - * > - * Copyright (c) 1998 > - * Jordan Hubbard. All rights reserved. > - * > - * Redistribution and use in source and binary forms, with or without > - * modification, are permitted provided that the following conditions > - * are met: > - * 1. Redistributions of source code must retain the above copyright > - * notice, this list of conditions and the following disclaimer, > - * verbatim and that no modifications are made prior to this > - * point in the file. > - * 2. Redistributions in binary form must reproduce the above copyright > - * notice, this list of conditions and the following disclaimer in th= e > - * documentation and/or other materials provided with the distributio= n. > - * > - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR > - * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR > PURPOSE > - * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR HIS PETS BE LIABLE > - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > CONSEQUENTIAL > - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOO= DS > - * OR SERVICES; LOSS OF USE, DATA, LIFE OR PROFITS; OR BUSINESS > INTERRUPTION) > - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, > STRICT > - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY > WAY > - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY O= F > - * SUCH DAMAGE. > - */ > - > -#include <sys/cdefs.h> > -#include <stdlib.h> > - > -#include <libutil.h> > - > -char * > -auth_getval(const char *name) > -{ > - > - (void)name; > - return (NULL); > -} > diff --git a/lib/libutil/libutil.h b/lib/libutil/libutil.h > index 6d36a0c291c6..d27262e44daf 100644 > --- a/lib/libutil/libutil.h > +++ b/lib/libutil/libutil.h > @@ -86,7 +86,6 @@ struct termios; > struct winsize; > > __BEGIN_DECLS > -char *auth_getval(const char *_name); > void clean_environment(const char * const *_white, > const char * const *_more_white); > int expand_number(const char *_buf, int64_t *_num); > > --=20 Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org --000000000000c14e23063b700719 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div><div>Hello!<br><br></div>Not sure if it is related bu= t I've spoted that lang/ghc is failing on configure on main-n279255-95f= 8c3e1ed0c: Sat Aug =C2=A02:<br><br>chmod 644 '/wrkdirs/usr/ports/lang/g= hc/work/ghc-boot-install/lib/ghc-9.6.7/lib/package.conf.d/template-haskell-= 2.20.0.0.conf'<br>'/wrkdirs/usr/ports/lang/ghc/work/ghc-boot-instal= l/lib/ghc-9.6.7/bin/ghc-pkg' --global-package-db "/wrkdirs/usr/por= ts/lang/ghc/work/ghc-boot-install/lib/ghc-9.6.7/lib/package.conf.d" re= cache<br>ld-elf.so.1: Shared object "libutil.so.9" not found, req= uired by "ghc-pkg"<br>gmake: *** [Makefile:235: update_package_db= ] Error 1<br><br></div>Thanks,</div><br><div class=3D"gmail_quote gmail_quo= te_container"><div dir=3D"ltr" class=3D"gmail_attr">Dag-Erling Sm=C3=B8rgra= v <<a href=3D"mailto:des@freebsd.org">des@freebsd.org</a>> escreveu (= s=C3=A1bado, 2/08/2025 =C3=A0(s) 18:57):<br></div><blockquote class=3D"gmai= l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20= 4,204);padding-left:1ex">The branch main has been updated by des:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D8d8a745c456cacf70= 6689febee9639f5e8292fc8" rel=3D"noreferrer" target=3D"_blank">https://cgit.= FreeBSD.org/src/commit/?id=3D8d8a745c456cacf706689febee9639f5e8292fc8</a><b= r> <br> commit 8d8a745c456cacf706689febee9639f5e8292fc8<br> Author:=C2=A0 =C2=A0 =C2=A0Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org>= <br> AuthorDate: 2025-08-02 17:56:16 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org>= <br> CommitDate: 2025-08-02 17:56:35 +0000<br> <br> =C2=A0 =C2=A0 libutil: Drop auth_getval()<br> <br> =C2=A0 =C2=A0 This function has been an empty stub for years; now that we&#= 39;re bumping<br> =C2=A0 =C2=A0 the library version, we can finally get rid of it.<br> <br> =C2=A0 =C2=A0 Fixes:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0c381b7f0570<br> =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 kib, emaste<br> =C2=A0 =C2=A0 Differential Revision:=C2=A0 <a href=3D"https://reviews.freeb= sd.org/D51704" rel=3D"noreferrer" target=3D"_blank">https://reviews.freebsd= .org/D51704</a><br> ---<br> =C2=A0lib/libutil/Makefile=C2=A0 =C2=A0|=C2=A0 2 +-<br> =C2=A0lib/libutil/Symbol.map |=C2=A0 1 -<br> =C2=A0lib/libutil/auth.c=C2=A0 =C2=A0 =C2=A0| 44 --------------------------= ------------------<br> =C2=A0lib/libutil/libutil.h=C2=A0 |=C2=A0 1 -<br> =C2=A04 files changed, 1 insertion(+), 47 deletions(-)<br> <br> diff --git a/lib/libutil/Makefile b/lib/libutil/Makefile<br> index d445bc5dec3b..12ac623aec6b 100644<br> --- a/lib/libutil/Makefile<br> +++ b/lib/libutil/Makefile<br> @@ -9,7 +9,7 @@ PACKAGE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 runtime<br> =C2=A0LIB=3D=C2=A0 =C2=A0util<br> =C2=A0SHLIB_MAJOR=3D 10<br> <br> -SRCS=3D=C2=A0 _secure_path.c auth.c cpuset.c expand_number.c flopen.c fpar= seln.c \<br> +SRCS=3D=C2=A0 _secure_path.c cpuset.c expand_number.c flopen.c fparseln.c = \<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 ftime.c getlocalbase.c gr_util.c \<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 hexdump.c humanize_number.c kinfo_getfile.c \<b= r> =C2=A0 =C2=A0 =C2=A0 =C2=A0 kinfo_getallproc.c kinfo_getproc.c kinfo_getvmm= ap.c \<br> diff --git a/lib/libutil/Symbol.map b/lib/libutil/Symbol.map<br> index d4bac5b5f53e..8c8fff451cd1 100644<br> --- a/lib/libutil/Symbol.map<br> +++ b/lib/libutil/Symbol.map<br> @@ -2,7 +2,6 @@ FBSD_1.8 {<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 _secure_path;<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 auth_cat;<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 auth_checknologin;<br> -=C2=A0 =C2=A0 =C2=A0 =C2=A0auth_getval;<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 auth_hostok;<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 auth_timeok;<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 auth_ttyok;<br> diff --git a/lib/libutil/auth.c b/lib/libutil/auth.c<br> deleted file mode 100644<br> index 3414fc8e26e7..000000000000<br> --- a/lib/libutil/auth.c<br> +++ /dev/null<br> @@ -1,44 +0,0 @@<br> -/*-<br> - * SPDX-License-Identifier: BSD-2-Clause<br> - *<br> - * Simple authentication database handling code.<br> - *<br> - * Copyright (c) 1998<br> - *=C2=A0 =C2=A0 =C2=A0Jordan Hubbard.=C2=A0 All rights reserved.<br> - *<br> - * Redistribution and use in source and binary forms, with or without<br> - * modification, are permitted provided that the following conditions<br> - * are met:<br> - * 1. Redistributions of source code must retain the above copyright<br> - *=C2=A0 =C2=A0 notice, this list of conditions and the following disclaim= er,<br> - *=C2=A0 =C2=A0 verbatim and that no modifications are made prior to this<= br> - *=C2=A0 =C2=A0 point in the file.<br> - * 2. Redistributions in binary form must reproduce the above copyright<br= > - *=C2=A0 =C2=A0 notice, this list of conditions and the following disclaim= er in the<br> - *=C2=A0 =C2=A0 documentation and/or other materials provided with the dis= tribution.<br> - *<br> - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRE= SS OR<br> - * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE<br> - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURP= OSE<br> - * ARE DISCLAIMED.=C2=A0 IN NO EVENT SHALL THE AUTHOR OR HIS PETS BE LIABL= E<br> - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENT= IAL<br> - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS= <br> - * OR SERVICES; LOSS OF USE, DATA, LIFE OR PROFITS; OR BUSINESS INTERRUPTI= ON)<br> - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STR= ICT<br> - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY W= AY<br> - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF<= br> - * SUCH DAMAGE.<br> - */<br> -<br> -#include <sys/cdefs.h><br> -#include <stdlib.h><br> -<br> -#include <libutil.h><br> -<br> -char *<br> -auth_getval(const char *name)<br> -{<br> -<br> -=C2=A0 =C2=A0 =C2=A0 =C2=A0(void)name;<br> -=C2=A0 =C2=A0 =C2=A0 =C2=A0return (NULL);<br> -}<br> diff --git a/lib/libutil/libutil.h b/lib/libutil/libutil.h<br> index 6d36a0c291c6..d27262e44daf 100644<br> --- a/lib/libutil/libutil.h<br> +++ b/lib/libutil/libutil.h<br> @@ -86,7 +86,6 @@ struct termios;<br> =C2=A0struct winsize;<br> <br> =C2=A0__BEGIN_DECLS<br> -char=C2=A0 =C2=A0*auth_getval(const char *_name);<br> =C2=A0void=C2=A0 =C2=A0clean_environment(const char * const *_white,<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 const char * const *_more_white);= <br> =C2=A0int=C2=A0 =C2=A0 expand_number(const char *_buf, int64_t *_num);<br> <br> </blockquote></div><div><br clear=3D"all"></div><br><span class=3D"gmail_si= gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d= iv dir=3D"ltr"><div><font color=3D"#888888">Nuno Teixeira</font></div><div>= <div><font color=3D"#888888"> FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 <a h= ref=3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank">https://Fr= eeBSD.org</a><br></font></div></div></div></div> --000000000000c14e23063b700719--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2Bj4i=PJ=gfdWdjGYtQYsdEJcF7Z2%2B8uahm1WLQK1b5=Q>