Date: Fri, 14 Dec 2007 02:11:51 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Kip Macy <kip.macy@gmail.com> Cc: Scott Long <scottl@samsco.org>, src-committers@freebsd.org, d@delphij.net, Kip Macy <kmacy@freebsd.org>, cvs-src@freebsd.org, cvs-all@freebsd.org, Julian Elischer <julian@elischer.org>, "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Subject: Re: cvs commit: src/sys/conf files src/sys/netinet tcp_ofld.c tcp_ofld.h tcp_var.h toedev.h src/sys/sys socket.h Message-ID: <20071214020704.A86532@fledge.watson.org> In-Reply-To: <b1fa29170712131748o7020308fsbbc47ede9b8d0c80@mail.gmail.com> References: <200712122021.lBCKLdvt045540@repoman.freebsd.org> <20071213223319.E81630@maildrop.int.zabbadoz.net> <4761BB7C.3010907@elischer.org> <b1fa29170712131605n106236bbvee862fe2d560bf0c@mail.gmail.com> <4761CB3F.3030905@delphij.net> <4761CDBA.9010906@samsco.org> <20071214005643.R86532@fledge.watson.org> <4761D791.5010003@samsco.org> <20071214011347.M86532@fledge.watson.org> <b1fa29170712131748o7020308fsbbc47ede9b8d0c80@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 Dec 2007, Kip Macy wrote: > On Dec 13, 2007 5:30 PM, Robert Watson <rwatson@freebsd.org> wrote Sadly, > often the only way to get a real discussion going is to make the immediacy > of it relevant. To date I haven't made any material structural changes to > TCP, I've only added the hooks that will be needed. As requested by another > I will add some commentary on the purpose of each of the individual hooks to > the header file. I'd certainly agree with the observation that it takes immediacy to force review and discussion to take place. However, I think it's also the case that continuous review of a significant WIP is very time-consuming for the reviewers. By structuring the review process a bit (i.e., identifying specific spots in the design, implementation, etc, where seeking review makes sense and there's a fairly fixed work product for someone to look at rather than a rapidly-moving target in which any comments are rapidly invalidated), I find I tend to receive much more productive reviews from others. Certainly, "The attached patch is going into the tree on/about date X" is the most effective technique, other than just committing the change, to prompt review... Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071214020704.A86532>