Date: Sun, 28 Dec 2008 15:30:59 -0800 From: "Kip Macy" <kmacy@freebsd.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: Qing Li <qingli@freebsd.org>, freebsd-net@freebsd.org Subject: Re: arp-v2 (void *)-1 "hack" Message-ID: <3c1674c90812281530l52b83404k9822cf6818329f01@mail.gmail.com> In-Reply-To: <20081228225956.G28465@maildrop.int.zabbadoz.net> References: <20081228225956.G28465@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> What do you think wrt to adding the (possibly optional) int *error and > returning the errno rather than a (void *)-1? If you'd be ok, I'd can > prepare the patch. I'd rather break the API now than in a few months. I would greatly prefer having a dedicated new function that calls in to it. There are a lot of calls to lla_lookup that would have to be changed needlessly. In other words: 1) lla_lookup_internal - a static function which takes all 3 args 2) lla_delete - which returns an errno 3) lla_lookup - which maintains the current interface I'll review the patch as soon as it is ready. -Kip
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3c1674c90812281530l52b83404k9822cf6818329f01>