Date: Fri, 26 Jun 2020 20:04:15 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Matt Macy <mmacy@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r362667 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace Message-ID: <94C5CFE0-2F25-44FA-B0B7-D6397D4EAC7A@gmail.com> In-Reply-To: <20200627010206.GA63841@FreeBSD.org> References: <202006270057.05R0vmgC070914@repo.freebsd.org> <20200627010206.GA63841@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 26, 2020, at 6:02 PM, Alexey Dokuchaev <danfe@FreeBSD.org> = wrote: >=20 > On Sat, Jun 27, 2020 at 12:57:48AM +0000, Matt Macy wrote: >> New Revision: 362667 >> URL: https://svnweb.freebsd.org/changeset/base/362667 >>=20 >> Log: >> Fix "current" variable name conflict with openzfs >>=20 >> The variable "current" is an alias for curthread >> in openzfs. Rename all variable uses of current >> in dtrace.c to curstate. >=20 > Shouldn't OpenZFS be fixed instead? The fact that we need to fix our > local variables suggests that they're abusing too generic name=E2=80=A6 I kind of agree with `current` being a bit too genericly named = in both DTrace and OpenZFS :/.. Cheers, -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?94C5CFE0-2F25-44FA-B0B7-D6397D4EAC7A>