Date: Thu, 3 Jun 2021 12:16:52 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Torsten Zuehlsdorff <freebsd@toco-domains.de> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Replacing USE_GCC=any and the danfe@ filter (was: svn commit: r568012 - head/net/tightvnc) Message-ID: <20210603101652.v2nk3kuvbayokd2g@aching.in.mat.cc> In-Reply-To: <0506d5b7-3a2e-89eb-8e72-238b7a3f3d4d@toco-domains.de> References: <f7316636-5fd2-cfd1-7661-3044fd782587@pfeifer.com> <20210603063235.676vy42y56fzvuu5@aching.in.mat.cc> <64998e65-5200-ba36-eb61-f54b26a6e2a8@toco-domains.de> <0506d5b7-3a2e-89eb-8e72-238b7a3f3d4d@toco-domains.de>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Jun 03, 2021 at 11:55:27AM +0200, Torsten Zuehlsdorff wrote: > > > On 03.06.21 11:50, Torsten Zuehlsdorff wrote: > > > > > > On 03.06.21 08:32, Mathieu Arnold wrote: > > > On Thu, Jun 03, 2021 at 12:22:47AM +0200, Gerald Pfeifer wrote: > > > > On Sun, 30 May 2021, Mathieu Arnold wrote: > > > > > Thank you for working on this. > > > > > > > > So, I was just ready to commit the next step and prepared a nice git > > > > style commit message: > > > > > > > > Replace USE_GCC=any with USE_GCC=yes > > > > USE_GCC=any has been equivalent to USE_GCC=yes in most cases (such > > > > as i386 and amd64 since 12.x and depending on configuration 11.x, > > > > most newer installations on other platforms, and 13.x across the > > > > board). > > > > Since commit 96c17633d90386b5bcf8 Mk/bsd.gcc.mk ... > > > > > > > > Alas, the danfe@ filter struck: > > > > > > > > remote: Resolving deltas: 100% (111/111), completed with 111 > > > > local objects. > > > > remote: > > > > remote: > > > > ================================================================ > > > > remote: First line does not start with the regular > > > > remote: category/port: subject > > > > remote: > > > > ================================================================ > > > > > > > > What now? > > > > > > > > Neither "*/*: Replace USE_GCC=any..." in the subject nor a couple dozen > > > > individual commits strike me as desirable. > > > > > > *: Replace... works just fine. > > > > This seems to be a transcription of "It works around a rule which has > > its purpose but should not be enforced 100% of the time". > > Also just for fun: this new rule violates our old rule about committing new > ports. It was always start with "New port $cat/$name". Or have we changed > this rule? Well, you can try, but you will not be able to push the commit, now we write `cat/port: new port blah`. For the same reason, all commit subjects starts the same, it is much much easier to scan quickly. -- Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmC4rBBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgIrPg/+IKdFS4Oq80v8d5QfUbMP2dV2qUQy3ItcxWZYKKjvLYUTolm9j4bDd7bU I+j14+F0yrZOppjE+VV5hZqgfYWDZ4jSK3uy5EXyRStiWbUKLYHZv9cM3xjUbRo9 JNS25USzMhjvKLSub51/1syctVZUaH1x5vjp8nU+BEjzcfoYB0tYnnITwb4Zs/p5 8loNwund/BhCH4EUDnTdDcke0SyE4CzJPx+1IWJlfxMwXtXvkJdGZ/W66Ai5trM5 U1LFUJoDs96X9ipnUprZqJVfvBgqxqBuy7gn/YGUlQfplk+P0wUWz1xIU89sIHO5 fTwqSy5/O4tVXfUIens3Bqt3ZFD9AP/BqfN6oWPBrNx1YovQuyWQDwSPXZRGsFsS NsVd3Nm5cl7VZJE6JOtHA5EqVc03HphBrf8jFlrU8PIpSZYb+J9FEh3bX46dzOM7 ClIL/4kGnf0ESTvnjwO/fe8Eh0HOkQ4hkaIM3m71XQtczz7eABxlLA9XCNpEf+wV 4mCabz/ToT5bxe8Fhr//F52ItgW8INWPmfxHNvZbbepBi+uDBmS6xDsI3eaVdLxd JoXoSZlCvpnWmK7mtWcI8ZXtodTtwA+VvalY9Ywep4yFY4k1mXdB0dU2WPn0MDkH T2b7ZWgTjggPOsHCdX+8dn+5GUiWgv8emXZrjdQ4pf8+yN2BY6k= =4Akv -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210603101652.v2nk3kuvbayokd2g>