Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 8 May 2025 03:35:41 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Olivier Certner <olce@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 0f2090ccfeb6 - main - kassert: Explicitly include <sys/_types.h>
Message-ID:  <aBv8XVpt5VXPKseg@kib.kiev.ua>
In-Reply-To: <202504281223.53SCNg4B025834@gitrepo.freebsd.org>
References:  <202504281223.53SCNg4B025834@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 28, 2025 at 12:23:42PM +0000, Olivier Certner wrote:
> The branch main has been updated by olce:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=0f2090ccfeb6e3e1a2290300b53baedfb057c2b5
> 
> commit 0f2090ccfeb6e3e1a2290300b53baedfb057c2b5
> Author:     Olivier Certner <olce@FreeBSD.org>
> AuthorDate: 2025-04-07 12:16:34 +0000
> Commit:     Olivier Certner <olce@FreeBSD.org>
> CommitDate: 2025-04-28 12:19:42 +0000
> 
>     kassert: Explicitly include <sys/_types.h>
>     
>     Include it as <sys/kassert.h> has direct references defined in it (to
>     '__va_list' and '__printflike' at least).
>     
>     This is a step to make <sys/kassert.h> usable without the need to
>     explicitly include other headers.
>     
>     Reviewed by:    imp, markj
>     MFC after:      3 days
>     Sponsored by:   The FreeBSD Foundation
>     Differential Revision:  https://reviews.freebsd.org/D49972
> ---
>  sys/sys/kassert.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sys/sys/kassert.h b/sys/sys/kassert.h
> index a2bc42058d93..e61eca308c07 100644
> --- a/sys/sys/kassert.h
> +++ b/sys/sys/kassert.h
> @@ -31,6 +31,7 @@
>  #ifndef _SYS_KASSERT_H_
>  #define	_SYS_KASSERT_H_
>  
> +#include <sys/_types.h>
>  #include <sys/cdefs.h>
cdefs.h must go first, I believe.

>  
>  #ifdef _KERNEL



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aBv8XVpt5VXPKseg>