Date: Mon, 6 Dec 2010 19:44:53 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Ivan Voras <ivoras@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <20101206184453.GA1936@garage.freebsd.pl> In-Reply-To: <201012061218.oB6CI3oW032770@svn.freebsd.org> References: <201012061218.oB6CI3oW032770@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Dec 06, 2010 at 12:18:03PM +0000, Ivan Voras wrote: > Author: ivoras > Date: Mon Dec 6 12:18:02 2010 > New Revision: 216230 > URL: http://svn.freebsd.org/changeset/base/216230 > > Log: > Use GEOM stripesize field when calculating ashift. This will enable correct > alignment on drives with large sector sizes (e.g. 4 KiB) but the > implementation might need to be revisited if devices with large stripesizes > appear (e.g. if RAID controllers or flash drives start using the field), > probably by introducing a physsectorsize field in GEOM providers. Please back this out as soon as possible! > Discussed with: mav, mostly silence on freebsd-geom@ and freebsd-fs@ Guess why it wasn't picked up by anyone? > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > ============================================================================== > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c Mon Dec 6 11:37:24 2010 (r216229) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c Mon Dec 6 12:18:02 2010 (r216230) > @@ -496,7 +496,10 @@ vdev_geom_open(vdev_t *vd, uint64_t *psi > /* > * Determine the device's minimum transfer size. > */ > - *ashift = highbit(MAX(pp->sectorsize, SPA_MINBLOCKSIZE)) - 1; > + if (pp->stripesize > pp->sectorsize) > + *ashift = highbit(MIN(pp->stripesize, SPA_MAXBLOCKSIZE)) - 1; > + else > + *ashift = highbit(MAX(pp->sectorsize, SPA_MINBLOCKSIZE)) - 1; Even in this chunk there is a comment explaining perfectly what ashift stands for!! -- Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkz9LyUACgkQForvXbEpPzQGzgCfQMaGcITMc8XXPnD+nVk1Pgei /MAAoKDqaJ/5bRNXzlP/wu62guEWpgcg =icls -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101206184453.GA1936>