Date: Sat, 12 Jan 2008 15:42:48 +0000 From: "Igor Mozolevsky" <igor@hybrid-lab.co.uk> To: "Kostik Belousov" <kostikbel@gmail.com> Cc: Dominic Fandrey <kamikaze@bsdforen.de>, freebsd-current@freebsd.org Subject: Re: Improving the handling of PR:s Message-ID: <a2b6592c0801120742y71d84965ldafca1db678f702a@mail.gmail.com> In-Reply-To: <20080112152303.GV57756@deviant.kiev.zoral.com.ua> References: <478556AD.6090400@bsdforen.de> <20080110003524.GB5188@soaustin.net> <200801111935.50821.peter.schuller@infidyne.com> <478887B4.9030906@bsdforen.de> <20080112152303.GV57756@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/01/2008, Kostik Belousov <kostikbel@gmail.com> wrote: > I taken the patch, because I though that > I have such card. After the truth revealed that I am not, I preferred to > not broke support for somebody hardware. If there are other users of the > same card, why do not they complain and test the patch ? This is fairly generic and doesn't necessarily just apply to your post, but here you expect the users to be *developers*; and while most people would happily try something pre-compiled, or at least merged into the source tree (so they can just do a make xxx), significantly fewer people would be wanting to experiment patching. Firstly you expect the users, most of whom are just trying the OS out, to dig through the PR database, then to patch the necessary files, configure their system (once they figure out how to edit the relevant KERNCONF file), and so on... Seriously, what's wrong with merging various patches into the source tree and surrounding them with #ifdef WITH_EXPERIMENTAL_CODE, or WITH_EXPERIMENTAL_(module name) and then allowing that in make.conf? At least that'll take the hassle of searching through PRs/mering... Alternative (for more advanced hackers) would be to have a dedicated page that lists various experimental patches categorized by module/subsystem/etc, which allows people to pull the experimental patches directly... Another alternative is to have a boolean flag on the PR so that the author can indicate that it's a patch and have the gnats mail a separate list of uncommitted patches separately to other open PRs? Igor
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a2b6592c0801120742y71d84965ldafca1db678f702a>