Date: Sun, 7 Sep 2014 09:53:55 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r271174 - head/sys/sys Message-ID: <20140907055355.GK17059@FreeBSD.org> In-Reply-To: <201409051646.s85GkSm0008980@svn.freebsd.org> References: <201409051646.s85GkSm0008980@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert, On Fri, Sep 05, 2014 at 04:46:28PM +0000, Robert Watson wrote: R> Author: rwatson R> Date: Fri Sep 5 16:46:28 2014 R> New Revision: 271174 R> URL: http://svnweb.freebsd.org/changeset/base/271174 R> R> Log: R> Clarify a diagnostic printf() in the mbuf code: M_EXT doesn't necessarily R> imply a cluster is attached; it could also refer to some other sort of R> external storage (e.g., an sf_buf). R> R> MFC after: 3 days R> Sponsored by: EMC / Isilon Storage Division R> R> Modified: R> head/sys/sys/mbuf.h R> R> Modified: head/sys/sys/mbuf.h R> ============================================================================== R> --- head/sys/sys/mbuf.h Fri Sep 5 16:40:47 2014 (r271173) R> +++ head/sys/sys/mbuf.h Fri Sep 5 16:46:28 2014 (r271174) R> @@ -672,7 +672,7 @@ m_clget(struct mbuf *m, int how) R> { R> R> if (m->m_flags & M_EXT) R> - printf("%s: %p mbuf already has cluster\n", __func__, m); R> + printf("%s: %p mbuf already has external storage\n", __func__, m); R> m->m_ext.ext_buf = (char *)NULL; R> uma_zalloc_arg(zone_clust, m, how); R> /* R> @@ -698,7 +698,7 @@ m_cljget(struct mbuf *m, int how, int si R> uma_zone_t zone; R> R> if (m && m->m_flags & M_EXT) R> - printf("%s: %p mbuf already has cluster\n", __func__, m); R> + printf("%s: %p mbuf already has external storage\n", __func__, m); R> if (m != NULL) R> m->m_ext.ext_buf = NULL; Shouldn't these be KASSERTs? I'm pretty sure that Andre put it as printf(9) because he was not sure it is correct. But since that time we never seen these prints in the wild, so they can be safely converted to KASSERTs. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140907055355.GK17059>