Date: Tue, 12 Feb 2013 22:44:00 +0100 From: Josef Pojsl <jp@tns.cz> To: freebsd-net@freebsd.org Subject: lacp on lagg interface: same speed, different media Message-ID: <511AB7A0.6020506@tns.cz>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------050700050103050000090502 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hello list, on a FreeBSD 8.3-RELEASE-p3, I have come across a problem with lacp protocol on a lagg interface. I have aggregated two interfaces with the same speed but slightly different type of media (namely 10Gbase-SR and 10Gbase-LR). There is a Cisco switch on the other side. LACP won't work as my FreeBSD box computes the actor key differently for the two interfaces. This is weird as LACP inists on the same speed but not on the same exact type of media. Cisco has no problem having one aggregated interface Short and the other Long Range. Below, I have attached a tiny patch that changes the actor key computation so that only speed is important, not the exact media type. This patch works for me, LACP is ok with the Cisco box on the other side. Please could someone competent look at the patch and test or evaluate if it can be included in the code base. Thank you. Regards, Josef --------------050700050103050000090502 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="lacp-speed.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="lacp-speed.patch" KioqIHN5cy9uZXQvaWVlZTgwMjNhZF9sYWNwLmMub3JpZwkyMDEzLTAyLTEyIDIxOjAzOjE2 LjAwMDAwMDAwMCArMDEwMAotLS0gc3lzL25ldC9pZWVlODAyM2FkX2xhY3AuYwkyMDEzLTAy LTEyIDIxOjEzOjM5LjAwMDAwMDAwMCArMDEwMAoqKioqKioqKioqKioqKioKKioqIDEwMjgs MTAzNSAqKioqCiAgCQlLQVNTRVJUKElGTV9UWVBFKG1lZGlhKSA9PSBJRk1fRVRIRVIsICgi aW52YWxpZCBtZWRpYSB0eXBlIikpOwogIAkJS0FTU0VSVCgobWVkaWEgJiBJRk1fRkRYKSAh PSAwLCAoImFnZ3JlZ2F0aW5nIEhEWCBpbnRlcmZhY2UiKSk7CiAgCiEgCQkvKiBiaXQgMC4u NDoJSUZNX1NVQlRZUEUgKi8KISAJCWtleSA9IHN1YnR5cGU7CiAgCQkvKiBiaXQgNS4uMTQ6 CShzb21lIGJpdHMgb2YpIGlmX2luZGV4IG9mIGxhZ2cgZGV2aWNlICovCiAgCQlrZXkgfD0g MHg3ZmUwICYgKChzYy0+c2NfaWZwLT5pZl9pbmRleCkgPDwgNSk7CiAgCQkvKiBiaXQgMTU6 CTAgKi8KLS0tIDEwMjgsMTA2MyAtLS0tCiAgCQlLQVNTRVJUKElGTV9UWVBFKG1lZGlhKSA9 PSBJRk1fRVRIRVIsICgiaW52YWxpZCBtZWRpYSB0eXBlIikpOwogIAkJS0FTU0VSVCgobWVk aWEgJiBJRk1fRkRYKSAhPSAwLCAoImFnZ3JlZ2F0aW5nIEhEWCBpbnRlcmZhY2UiKSk7CiAg CiEgCQkvKiBiaXQgMC4uNDoJSUZNX1NVQlRZUEUgbW9kdWxvIHNwZWVkICovCiEgCQlzd2l0 Y2ggKHN1YnR5cGUpIHsKISAJCWNhc2UgSUZNXzEwX1Q6CiEgCQljYXNlIElGTV8xMF8yOgoh IAkJY2FzZSBJRk1fMTBfNToKISAJCWNhc2UgSUZNXzEwX1NUUDoKISAJCWNhc2UgSUZNXzEw X0ZMOgohIAkJCWtleSA9IElGTV8xMF9UOyBicmVhazsKISAJCWNhc2UgSUZNXzEwMF9UWDoK ISAJCWNhc2UgSUZNXzEwMF9GWDoKISAJCWNhc2UgSUZNXzEwMF9UNDoKISAJCWNhc2UgSUZN XzEwMF9WRzoKISAJCWNhc2UgSUZNXzEwMF9UMjoKISAJCQlrZXkgPSBJRk1fMTAwX1RYOyBi cmVhazsKISAJCWNhc2UgSUZNXzEwMDBfU1g6CiEgCQljYXNlIElGTV8xMDAwX0xYOgohIAkJ Y2FzZSBJRk1fMTAwMF9DWDoKISAJCWNhc2UgSUZNXzEwMDBfVDoKISAJCQlrZXkgPSBJRk1f MTAwMF9TWDsgYnJlYWs7CiEgCQljYXNlIElGTV8xMEdfTFI6CiEgCQljYXNlIElGTV8xMEdf U1I6CiEgCQljYXNlIElGTV8xMEdfQ1g0OgohIAkJY2FzZSBJRk1fMTBHX1RXSU5BWDoKISAJ CWNhc2UgSUZNXzEwR19UV0lOQVhfTE9ORzoKISAJCWNhc2UgSUZNXzEwR19MUk06CiEgCQlj YXNlIElGTV8xMEdfVDoKISAJCQlrZXkgPSBJRk1fMTBHX0xSOyBicmVhazsKISAJCWRlZmF1 bHQ6CiEgCQkJa2V5ID0gc3VidHlwZTsKISAJCX0KICAJCS8qIGJpdCA1Li4xNDoJKHNvbWUg Yml0cyBvZikgaWZfaW5kZXggb2YgbGFnZyBkZXZpY2UgKi8KICAJCWtleSB8PSAweDdmZTAg JiAoKHNjLT5zY19pZnAtPmlmX2luZGV4KSA8PCA1KTsKICAJCS8qIGJpdCAxNToJMCAqLwo= --------------050700050103050000090502--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?511AB7A0.6020506>