Date: Sun, 22 Feb 2004 13:57:50 -0500 From: Mathew Kanner <mat@cnd.mcgill.ca> To: Scott Long <scottl@FreeBSD.org> Cc: Mathew Kanner <mat@cnd.mcgill.ca> Subject: Re: cvs commit: src/sys/alpha/alpha mem.c promcons.c src/sys/alpha/tlsb zs_tlsb.c src/sys/amd64/amd64 mem.c src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_ch.c scsi_pass.c scsi_pt.cs Message-ID: <20040222185750.GE20226@cnd.mcgill.ca> In-Reply-To: <403800F0.9080504@freebsd.org> References: <200402212110.i1LLAtEX008732@repoman.freebsd.org> <20040221154636.U52892@pooker.samsco.home> <20040222010801.GC20226@cnd.mcgill.ca> <403800F0.9080504@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
> There is also ltmdm and nvidia, and both are affected by this. I can
> probably look at both tonight unless someone beats me to it.
Attached are patches for the ltmdm and nvidia ports. It
should suffice to drop them in the files subdir of the port. I've at
least tested the nvidia one since I have the hardware. They should be
also tested on a pre-cdev mega-patch kernel.
I should note that when nvidia module was rejected (wrong
version) on it panic'ed on kldunload with free wrong memtype. I'm
sorry for not capturing the details.
It's my hope that some with porting experience can get these
into the tree, pehaps with a friendly reminder to update you
out-of-tree modules in UPDATING. I'm not sure where source picks up
the freebsd-version so you may have to re-installed the sys header
files.
--Mat
--
Any idiot can face a crisis; it is this day-to-day living
that wears you out.
- Chekhov
[-- Attachment #2 --]
--- src/nvidia_ctl.c.old Sun Feb 22 13:05:46 2004
+++ src/nvidia_ctl.c Sun Feb 22 13:07:25 2004
@@ -43,7 +43,12 @@
.d_ioctl = nvidia_ctl_ioctl,
.d_poll = nvidia_ctl_poll,
.d_name = "nvidiactl",
+#if __FreeBSD_version < 502103
.d_maj = CDEV_MAJOR,
.d_flags = D_TRACKCLOSE
+#else
+ .d_version = D_VERSION,
+ .d_flags = D_NEEDGIANT
+#endif
#endif
};
[-- Attachment #3 --]
--- src/nvidia_dev.c.old Wed May 28 12:51:52 2003
+++ src/nvidia_dev.c Sun Feb 22 13:36:25 2004
@@ -45,7 +45,12 @@
.d_poll = nvidia_dev_poll,
.d_mmap = nvidia_dev_mmap,
.d_name = "nvidia",
+#if __FreeBSD_version < 502103
.d_maj = CDEV_MAJOR,
.d_flags = D_MEM|D_TRACKCLOSE
+#else
+ .d_version = D_VERSION,
+ .d_flags = D_MEM|D_TRACKCLOSE|D_NEEDGIANT
+#endif
#endif
};
[-- Attachment #4 --]
--- sys/dev/ltmdm/ltmdmsio.c.old Sun Feb 22 13:12:24 2004
+++ sys/dev/ltmdm/ltmdmsio.c Sun Feb 22 13:13:38 2004
@@ -407,11 +407,16 @@
.d_ioctl = sioioctl,
.d_poll = ttypoll,
.d_name = driver_name,
+#if __FreeBSD_version < 502103
#ifdef MAJOR_AUTO
.d_maj = MAJOR_AUTO,
#else
.d_maj = CDEV_MAJOR,
#endif
+#else
+ .d_version = D_VERSION,
+ .d_flags = D_NEEDGIANT,
+#endif
.d_kqfilter = ttykqfilter,
#endif
};
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040222185750.GE20226>