Date: Tue, 6 Apr 2021 20:16:39 +0200 From: Matthias Andree <mandree@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e098d24a5ace - main - security/openvpn-devel: Update to 2021-W13 development snapshot Message-ID: <df3f0781-e302-1cd9-2204-a9aff619de3c@FreeBSD.org> In-Reply-To: <20210406181107.GA52660@FreeBSD.org> References: <202104061733.136HXSHh054279@gitrepo.freebsd.org> <20210406181107.GA52660@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
Am 06.04.21 um 20:11 schrieb Alexey Dokuchaev: > On Tue, Apr 06, 2021 at 05:33:28PM +0000, Matthias Andree wrote: >> commit e098d24a5aceebd6924b41a980ebb135a1dec0ed >> Author: Matthias Andree <mandree@FreeBSD.org> >> ... >> PR: 254785 >> Submitted by: Eric F. Crist (maintainer) >> -- Diese und die folgenden Zeilen werden ignoriert -- >> > Description of fields to fill in above: 76 columns --| >> > PR: If and which Problem Report is related. >> > Submitted by: If someone else sent in the change. >> > Reported by: If someone else reported the issue. >> > Reviewed by: If someone else reviewed your modification. >> > Approved by: If you needed approval for this commit. >> > Obtained from: If the change is from a third party. > > I was under impression that transition to git, where commit and push are > separated, and one can (and should) always review it and --amend if deems > necessary, these would not happen anymore. How could this happen? Hi Alexey, Yeah, it should not have happened. There was a combination of events: - I was unaware that we were migrating to Git these days and the SVN commit failed with a read-only file system, and recycled the Git commit for svn-commit.tmp with "git commit -F /path/to/svn-commit.tmp" without giving it any thought, and without the commit message preparation hook in place (not sure if that matters, didn't exactly check when it runs). - I was using the saved commit message from Git, pulling for rebase, and pushing it, right away. I also didn't set the Submitter to be the Author, which I could have, because this is basically a transplanted SVN commit and not something originally Git. This is unlikely to happen repeatedly on my pushes, if that's your concern. Regards, Matthiashome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?df3f0781-e302-1cd9-2204-a9aff619de3c>