Date: Mon, 7 Jul 2025 15:24:23 +0000 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Mark Johnston <markj@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 71a0af25a535 - main - libopenbsd: Add recallocarray() Message-ID: <avnebrtztq2cpw4h4tsboskpcnszgbgmg53rmyu7dnmud27x6k@suz6cbr34nlm> In-Reply-To: <aGvlu9Hd6VYfjM_i@nuc> References: <202507062318.566NIhSM031303@gitrepo.freebsd.org> <e33uojkaos2iqt2e2ogywagyi7uy6xq2u362gdn4iqhk3gosmp@ywifwaebxltw> <aGvlu9Hd6VYfjM_i@nuc>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jul 07, 2025 at 11:20:27AM -0400, Mark Johnston wrote: > On Mon, Jul 07, 2025 at 03:13:29PM +0000, Shawn Webb wrote: > > Hey Mark, > > > > I've noted a couple things. > > > > On Sun, Jul 06, 2025 at 11:18:43PM +0000, Mark Johnston wrote: > > > The branch main has been updated by markj: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=71a0af25a5353f929521cb04c73a7266ac5b7b61 > > > > > > commit 71a0af25a5353f929521cb04c73a7266ac5b7b61 > > > Author: Ricardo Branco <rbranco@suse.de> > > > AuthorDate: 2025-06-16 21:41:48 +0000 > > > Commit: Mark Johnston <markj@FreeBSD.org> > > > CommitDate: 2025-07-06 23:09:00 +0000 > > > > > > libopenbsd: Add recallocarray() > > > > > > Reviewed by: kib > > > MFC after: 1 month > > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1698 > > > > That appears to be the PR for POSIX O_CLOFORK. > > Correct. > > > > --- > > > lib/libopenbsd/Makefile | 3 +- > > > lib/libopenbsd/recallocarray.c | 82 ++++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 84 insertions(+), 1 deletion(-) > > > > FreeBSD commit 450dfafb1519ae7bb0615368ba45813bcabb9b35 back in 2015 > > imported a different version of OpenBSD's reallocarray into libc. > > Would it make sense to have only one reallocarray implementation? Or > > what's the justification for having two implementations of the same > > function? What might happen if someone links against both libc and > > libopenbsd? > > Note, this is recallocarray(), not reallocarray(). libc has the latter, > this commit added an implementation of the former to libopenbsd. What a difference one letter can make, haha. I certainly missed the extra "c". Sorry for the noise and thanks for the clarification. -- Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmhr5pcACgkQ/y5nonf4 4fqJfA/8C0ihGJmFHiLheWZdWZPWlOMcCeMTL7qIs44GYpyN0i3w9Ie6d/sGSnbS N7FNFtx9LzKAo+Q6pyfgU852LvwCLHdTqYgY/McIfkPT7v2OJdPl7v0SS0fG6u5j TUVsH3Sjiaao/ESdTkoehNPRZbOYz0t81SIpb5RBDKhr2fLnTpWdZsGJQp3tXzY4 7fZXzR6e3hPQTgnQYidPkmEu2Q8JrwlZsKQPOO/z2c9tZwLFhwa3yelduffj3bm4 AldyT0tNFr0HE1PlhdYawkDYrZQ8z0XS4pxM/Z3U1HjaCk5Ok0ti0GhFWBau+Kue GHpRJTkQObVJ7Mrq+S52TU9p0qmKSEnBZw4vLhYBGGaNsBW7SelT5PqdvL3bg0Di NBb+lsUkCGmLSxGJmpFow4bAhQ9pzBxhiIQ2s2vZEmW0tsRvOgn52Rtn6P287Qo+ LzSo49+jWE40EUt4bzPUo+n8+NCHXaCeIJTcEkeorrcb5ypU9YkpFtcnJWL2iu74 YJTTDnmqKK2jU78JVmkP1ZRP0aA+/yHpcJXpRzjIbblCMASdzhbCF8Oq1Jf0mMVY HgJ298WOBf2lJdXtS5snQk3TIUhaVGioDJH75w0p8lQ0lPb8HeK+e/1AXROTLwK8 UK15Iiirhm1tReHCN9KWFL4Nixj4Cvsr3blaigJXtD7G+tnQs1o= =8Mz7 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?avnebrtztq2cpw4h4tsboskpcnszgbgmg53rmyu7dnmud27x6k>