Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Apr 2014 19:10:23 +0000 (UTC)
From:      Rick Macklem <rmacklem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r264738 - head/sys/fs/nfsclient
Message-ID:  <201404211910.s3LJANkb082584@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rmacklem
Date: Mon Apr 21 19:10:23 2014
New Revision: 264738
URL: http://svnweb.freebsd.org/changeset/base/264738

Log:
  For an NFSv4 mount with the "nocto" option, don't get the
  up to date file attributes upon close. This reduces the
  Getattr RPC count by about 65% for software builds.
  
  MFC after:	2 weeks

Modified:
  head/sys/fs/nfsclient/nfs_clvnops.c

Modified: head/sys/fs/nfsclient/nfs_clvnops.c
==============================================================================
--- head/sys/fs/nfsclient/nfs_clvnops.c	Mon Apr 21 17:40:23 2014	(r264737)
+++ head/sys/fs/nfsclient/nfs_clvnops.c	Mon Apr 21 19:10:23 2014	(r264738)
@@ -767,7 +767,9 @@ nfs_close(struct vop_close_args *ap)
 		/*
 		 * Get attributes so "change" is up to date.
 		 */
-		if (error == 0 && nfscl_mustflush(vp) != 0) {
+		if (error == 0 && nfscl_mustflush(vp) != 0 &&
+		    vp->v_type == VREG &&
+		    (VFSTONFS(vp->v_mount)->nm_flag & NFSMNT_NOCTO) == 0) {
 			ret = nfsrpc_getattr(vp, cred, ap->a_td, &nfsva,
 			    NULL);
 			if (!ret) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404211910.s3LJANkb082584>