Date: Thu, 26 Jan 2017 15:59:35 +0000 From: "decui_microsoft.com (Dexuan Cui)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h Message-ID: <6f051b4d23dc60c55c963dcffd4cc4b8@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-ehgwxeotuhsw6eo52uz6-req@FreeBSD.org> References: <differential-rev-PHID-DREV-ehgwxeotuhsw6eo52uz6-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
decui_microsoft.com added inline comments. INLINE COMMENTS > David_A_Bright_DELL.com wrote in if_var.h:407 > No objection to "Interface ..." but then I'd use "Interface up/down event" (the "if" in "ifdown" meaning "interface" is redundant). > > But, then, this is a nit. I don't strongly object to the patch as-is. Oh... Sorry, my bad! I failed to understand what you meant -- it's late at night here and obviously my eyes or brain didn't work very good :-) REVISION DETAIL https://reviews.freebsd.org/D9345 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: decui_microsoft.com, hselasky, sepherosa_gmail.com, cem, np, kmacy, kib, honzhan_microsoft.com, howard0su_gmail.com, jhb, ae, delphij, royger, glebius, gnn, rwatson, David_A_Bright_DELL.com Cc: David_A_Bright_DELL.com, freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6f051b4d23dc60c55c963dcffd4cc4b8>