Date: Wed, 17 May 2017 19:44:01 -0700 From: Alexander Motin <mav@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310230 - head/sys/cam/scsi Message-ID: <32cea555-27c9-555e-405b-1303bcd7ae17@FreeBSD.org> In-Reply-To: <bbf08100-1ea5-bd26-e5c7-0425625ba702@FreeBSD.org> References: <201612181502.uBIF2o4a023448@repo.freebsd.org> <bbf08100-1ea5-bd26-e5c7-0425625ba702@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17.05.2017 19:00, Bryan Drewery wrote: > On 12/18/16 7:02 AM, Alexander Motin wrote: >> Author: mav >> Date: Sun Dec 18 15:02:50 2016 >> New Revision: 310230 >> URL: https://svnweb.freebsd.org/changeset/base/310230 >> >> Log: >> Don't treat informational exceptions (warnings and impending failures) >> a.k.a. SCSI SMART events as errors. Log them to console and continue. >> >> MFC after: 2 weeks >> >> Modified: >> head/sys/cam/scsi/scsi_all.c >> >> Modified: head/sys/cam/scsi/scsi_all.c >> ============================================================================== >> --- head/sys/cam/scsi/scsi_all.c Sun Dec 18 14:54:20 2016 (r310229) >> +++ head/sys/cam/scsi/scsi_all.c Sun Dec 18 15:02:50 2016 (r310230) >> @@ -1233,58 +1233,58 @@ static struct asc_table_entry asc_table[ >> { SST(0x0A, 0x00, SS_FATAL | ENOSPC, >> "Error log overflow") }, >> /* DTLPWROMAEBKVF */ >> - { SST(0x0B, 0x00, SS_RDEF, >> + { SST(0x0B, 0x00, SS_NOP | SSQ_PRINT_SENSE, > > After this change (removing SS_RETRY), will a retry still occur on the > changed SENSE exceptions via something else? There will be no retry, since it is no longer considered an error. It is successful command completion status. The command will complete normally after just logging the status for administrative purposes. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?32cea555-27c9-555e-405b-1303bcd7ae17>