Date: Thu, 22 Jan 2015 16:26:58 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Will Andrews <will@FreeBSD.org>, gibbs@FreeBSD.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r277511 - head/sys/dev/firewire Message-ID: <D23E70CE-2741-4321-BDCB-DB2F5BF7DE19@FreeBSD.org> In-Reply-To: <201501212008.t0LK8PhR001309@svn.freebsd.org> References: <201501212008.t0LK8PhR001309@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 21 Jan 2015, at 20:08 , Will Andrews <will@FreeBSD.org> wrote: >=20 > Author: will > Date: Wed Jan 21 20:08:24 2015 > New Revision: 277511 > URL: https://svnweb.freebsd.org/changeset/base/277511 >=20 > Log: > Fix remote DMA based firewire debugging when targeting > systems with more than 4GB of physical memory. >=20 > To remotely debug the system 'stealthy' which has a kernel > with this change installed and firewire properly configured: >=20 > % fwcontrol -m stealthy (or stealthy's firewire EUI64) > % kgdb kernel /dev/fwmem0.0 >=20 > sys/dev/firewire/fwohci.c: > Rather than hard code the upper limit for hw based > automatic responses to remote DMA requests at 4GB, > program the hardware using Maxmem, the page number > one higher than the highest physical page detected > in the system. >=20 > While here, garbage collect more useless splfw() > calls. >=20 > Submitted by: gibbs > MFC after: 1 week > Sponsored by: Spectra Logic > MFSpectraBSD: 1110994 on 2015/01/06 arm doesn=E2=80=99t define a Maxmem; the kernel builds are thus = currently broken. converting beaglebone.dts -> = /storage/head/obj/arm.armv6/scratch/tmp/bz/head.svn/sys/BEAGLEBONE/beagleb= one.dtb = /scratch/tmp/bz/head.svn/sys/modules/firewire/firewire/../../../dev/firewi= re/fwohci.c:1856:28: error: use of undeclared identifier 'Maxmem' prequpper =3D ((uintmax_t)Maxmem << PAGE_SHIFT) = >> 16; ^ = /scratch/tmp/bz/head.svn/sys/modules/firewire/firewire/../../../dev/firewi= re/fwohci.c:1862:20: error: use of undeclared identifier 'Maxmem' (uintmax_t)Maxmem << PAGE_SHIFT, ^ 2 errors generated. =E2=80=94=20 Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D23E70CE-2741-4321-BDCB-DB2F5BF7DE19>