Date: Fri, 19 Jan 2018 13:11:14 +0100 From: Hans Petter Selasky <hps@selasky.org> To: rgrimes@freebsd.org, Kristof Provost <kp@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327676 - head/sys/compat/linuxkpi/common/include/linux Message-ID: <cc6e6930-a68b-4ca1-e9c2-e5cd6ea0c1f6@selasky.org> In-Reply-To: <201801071907.w07J7pUF018031@pdx.rh.CN85.dnsmgr.net> References: <201801071907.w07J7pUF018031@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/07/18 20:07, Rodney W. Grimes wrote:
>> -static inline void *
>> -kcalloc(size_t n, size_t size, gfp_t flags)
>> -{
>> - flags |= __GFP_ZERO;
>> - return (mallocarray(n, size, M_KMALLOC, linux_check_m_flags(flags)));
>> -}
>> -
>> static inline void *
>> __vmalloc(size_t size, gfp_t flags, int other)
>> {
>>
>> Regards,
>> Kristof
>
> Should probably revert and go through review,
> I would at least wait for comments from others.
>
Hi,
I think the current version is fine. The compiler should take care of
the inlining so that it doesn't consume additional stack.
Else create a review as suggested.
BTW: I need mallocarray() MFC'ed to 11-stable, but only the kernel
parts. I'm handling the MFC of the LinuxKPI parts.
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cc6e6930-a68b-4ca1-e9c2-e5cd6ea0c1f6>