Date: Wed, 5 Oct 2016 14:37:23 +0200 From: Torfinn Ingolfsen <torfinn.ingolfsen@getmail.no> To: freebsd-stable@freebsd.org Subject: Re: aibs(4) / atk0110 support for newer systems Message-ID: <20161005143723.4273657959160b67637a5adf@getmail.no> In-Reply-To: <f9fbb905-2bd7-0b1d-3baa-85061258718d@FreeBSD.org> References: <86cf8380-ac6f-55f0-f0f8-16000d7f04b2@FreeBSD.org> <20160930145704.4dbc9d90011154b38493964e@getmail.no> <7d498084-ec05-d4c9-5f49-6aef32495caf@FreeBSD.org> <20160930205928.77d7e74f7bd1a35fcf1aa50a@getmail.no> <7a868c22-e0bd-f677-e4ad-2bdf6f3605d0@FreeBSD.org> <20161003201511.7258687453f12c44a46a361a@getmail.no> <f9fbb905-2bd7-0b1d-3baa-85061258718d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 3 Oct 2016 23:05:48 +0300 Andriy Gapon <avg@FreeBSD.org> wrote: > Yes, it does. Thank you! > It seems like a couple of minor changes are not in the source tree that you are > using. One is some casts in a diagnostic printf and the other is a different > rounding of 0C in Kelvins. > I've generated a patch that should apply to your tree: > https://people.freebsd.org/~avg/aibs-ggrp-gitm.93.diff > Please try. The patch applied cleanly (I removed the old one with patch -R first): root@kg-core1# patch -p0 < /home/tingo/dl/aibs-ggrp-gitm.93.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/dev/acpi_support/atk0110.c |=================================================================== |--- sys/dev/acpi_support/atk0110.c (revision 306109) |+++ sys/dev/acpi_support/atk0110.c (working copy) -------------------------- Patching file sys/dev/acpi_support/atk0110.c using Plan A... Hunk #1 succeeded at 28. Hunk #2 succeeded at 52. Hunk #3 succeeded at 78. Hunk #4 succeeded at 91. Hunk #5 succeeded at 124. Hunk #6 succeeded at 134. Hunk #7 succeeded at 362. Hunk #8 succeeded at 370. Hunk #9 succeeded at 377. Hunk #10 succeeded at 391. Hunk #11 succeeded at 435. Hunk #12 succeeded at 450. Hunk #13 succeeded at 457. Hunk #14 succeeded at 488. Hunk #15 succeeded at 495. done However, build fails: root@kg-core1# pwd /sys/modules/acpi/aibs root@kg-core1# make Warning: Object directory not changed from original /usr/src/sys/modules/acpi/aibs @ -> /usr/src/sys machine -> /usr/src/sys/amd64/include x86 -> /usr/src/sys/x86/include :> opt_acpi.h awk -f @/tools/makeobjops.awk @/dev/acpica/acpi_if.m -h awk -f @/tools/makeobjops.awk @/kern/bus_if.m -h awk -f @/tools/makeobjops.awk @/kern/device_if.m -h :> opt_ddb.h cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -c /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c -o atk0110.o cc1: warnings being treated as errors /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c: In function 'aibs_attach': /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:252: warning: 's_idx' may be used uninitialized in this function /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:252: note: 's_idx' was declared here /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:256: warning: 'so' may be used uninitialized in this function /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:256: note: 'so' was declared here /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:253: warning: 'name' may be used uninitialized in this function /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:253: note: 'name' was declared here *** [atk0110.o] Error code 1 Stop in /usr/src/sys/modules/acpi/aibs. Do I have to do something more in order to build the new module? -- Torfinn Ingolfsen <torfinn.ingolfsen@getmail.no>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161005143723.4273657959160b67637a5adf>