Date: Mon, 16 Aug 1999 10:20:12 +0100 From: Nik Clayton <nik@freebsd.org> To: Greg Lehey <grog@lemis.com> Cc: Mike Pritchard <mpp@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: FDP committers, and changes to src/* Message-ID: <19990816102012.A10852@kilt.nothing-going-on.org> In-Reply-To: <19990816085437.E799@freebie.lemis.com>; from Greg Lehey on Mon, Aug 16, 1999 at 08:54:37AM %2B0930 References: <199908151217.FAA18539@freefall.freebsd.org> <19990816085437.E799@freebie.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-committers,
On Mon, Aug 16, 1999 at 08:54:37AM +0930, Greg Lehey wrote:
> On Sunday, 15 August 1999 at 5:17:00 -0700, Mike Pritchard wrote:
> > mpp 1999/08/15 05:17:00 PDT
> > Log:
> > Minor mdoc fix.
> >
> > Revision Changes Path
> > 1.26 +2 -2 src/sbin/vinum/vinum.8
>
> Since I'm actively maintaining these files, I'd appreciate if you'd
> contact me before changing them.
As a general point for all Doc. Proj. committers -- whenever you want to
commit outside of doc/ (even if there's a PR associated with the change)
to run it past whoever was the last person to touch the file first, just
to make sure (or check for a "MAINTAINER=" line in the Makefile, and
contact the maintainer). If it's a more general change, run it past
-hackers first.
Then wait 48 hours or so (longer if it's over a weekend) before doing
anything.
There are two typical responses to these sorts of requests for review. One
is a deafening silence, in which case just go and do it. The other is a
300 message thread about whether or not a colon should have been used
instead of a semi-colon.
In all cases where someone has actually reviewed the changes, don't forget
to include a "Reviewed by:" line in the commit message (and remember, this
is not necessary if the person doing the reviewing is the person doing the
committing -- it is assumed that the committer has already reviewed the
patch carefully. . .)
This is the grease that helps the commit wheel move more smoothly.
N
--
[intentional self-reference] can be easily accommodated using a blessed,
non-self-referential dummy head-node whose own object destructor severs
the links.
-- Tom Christiansen in <375143b5@cs.colorado.edu>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990816102012.A10852>