Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Dec 2018 09:21:34 -0800
From:      John Baldwin <jhb@FreeBSD.org>
To:        Konstantin Belousov <kib@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r341689 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys
Message-ID:  <e9e457ed-00f5-705e-55ea-1ad602f34ef0@FreeBSD.org>
In-Reply-To: <201812071517.wB7FHTiI035911@repo.freebsd.org>
References:  <201812071517.wB7FHTiI035911@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12/7/18 7:17 AM, Konstantin Belousov wrote:
> Author: kib
> Date: Fri Dec  7 15:17:29 2018
> New Revision: 341689
> URL: https://svnweb.freebsd.org/changeset/base/341689
> 
> Log:
>   Add new file handle system calls.
>   
>   Namely, getfhat(2), fhlink(2), fhlinkat(2), fhreadlink(2).  The
>   syscalls are provided for a NFS userspace server (nfs-ganesha).
>   
>   Submitted by:	Jack Halford <jack@gandi.net>
>   Sponsored by:	Gandi.net
>   Tested by:	pho
>   Feedback from:	brooks, markj
>   MFC after:	1 week
>   Differential revision:	https://reviews.freebsd.org/D18359

Can this be used to implement 'flink' (create a link to an open file
descriptor)?  Hmm, it appears so.  It is limited to PRIV_VFS_GETFH at least.
The getfh(2) manpage notes this explicitly, but the new manpages don't
appear to.  Even with the PRIV check, I'm still somewhat nervous about what
flink means for processes running as root that are using Capsicum.  Maybe
it's ok, but I didn't see any discussion of this in the review.

-- 
John Baldwin

                                                                            



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e9e457ed-00f5-705e-55ea-1ad602f34ef0>