Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Mar 2021 16:13:41 GMT
From:      Ryan Moeller <freqlabs@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 57593b2bca76 - stable/12 - align nfsdumpstate column output
Message-ID:  <202103291613.12TGDfYx042290@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by freqlabs:

URL: https://cgit.FreeBSD.org/src/commit/?id=57593b2bca76db683ec6c589c1b051132181d55b

commit 57593b2bca76db683ec6c589c1b051132181d55b
Author:     Caleb St. John <yocalebo@gmail.com>
AuthorDate: 2021-03-24 20:33:41 +0000
Commit:     Ryan Moeller <freqlabs@FreeBSD.org>
CommitDate: 2021-03-29 15:13:06 +0000

    align nfsdumpstate column output
    
    There are scenarios where an NFS client will mount an NFSv4 export
    without specifying a callback address.
    
    When running nfsdumpstate under this circumstance, the column output is
    shifted incorrectly which places the "ClientID" value underneath the
    "Clientaddr" column.
    
    This diff is a small cosmetic change that prints a blank in the
    "Clientaddr" column and ensures the data for the columns are aligned
    appropriately.
    
    Submitted by:   Caleb St. John
    Reviewed by:    sef (previous version)
    MFC after:      3 days
    Sponsored by:   iXsystems, Inc.
    Differential Revision:  https://reviews.freebsd.org/D18958
    
    (cherry picked from commit efad9c8ba3cec7f6e39b128b90afab70701fd8d9)
---
 usr.sbin/nfsdumpstate/nfsdumpstate.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/usr.sbin/nfsdumpstate/nfsdumpstate.c b/usr.sbin/nfsdumpstate/nfsdumpstate.c
index 4334a3ddf506..c7e086655f79 100644
--- a/usr.sbin/nfsdumpstate/nfsdumpstate.c
+++ b/usr.sbin/nfsdumpstate/nfsdumpstate.c
@@ -162,6 +162,9 @@ dump_openstate(void)
 				printf("%-45s ", " ");
 			break;
 #endif
+		default:
+			printf("%-45s ", " ");
+			break;
 		}
 		for (i = 0; i < dp[cnt].ndcl_clid.nclid_idlen; i++)
 			printf("%02x", dp[cnt].ndcl_clid.nclid_id[i]);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202103291613.12TGDfYx042290>