Date: Fri, 16 Mar 2007 11:16:12 +0000 From: Ceri Davies <ceri@submonkey.net> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libufs type.c Message-ID: <20070316111612.GZ53780@submonkey.net> In-Reply-To: <200703160313.l2G3DTHP048236@repoman.freebsd.org> References: <200703160313.l2G3DTHP048236@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--UvwuEPigQXXfOf7G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Mar 16, 2007 at 03:13:29AM +0000, Pawel Jakub Dawidek wrote:
> pjd 2007-03-16 03:13:29 UTC
>=20
> FreeBSD src repository
>=20
> Modified files:
> lib/libufs type.c=20
> Log:
> The ufs_disk_fillout(3) can take special device name (with or without /=
dev/
> prefix) as an argument and mount point path. At the end it has to find
> device name file system is stored on, which means when mount point path=
is
> given, it tries to look into /etc/fstab and find special device
> corresponding to the given mount point. This is not perfect, because it
> doesn't handle the case when file system is mounted by hand and mount p=
oint
> is given as an argument.
> =20
> I found this problem while trying to use snapinfo(8), which passes mount
> points to the ufs_disk_fillout(3) function, but I had file system mount=
ed
> manually, so snapinfo(8) was exiting with the error below:
> =20
> ufs_disk_fillout: No such file or directory
> =20
> I modified libufs(3) to handle those arguments (the order is important):
> =20
> 1. special device with /dev/ prefix
> 2. special device without /dev/ prefix
> 3. mount point listed in /etc/fstab, directory exists
> 4. mount point listed in /etc/fstab, directory doesn't exist
> 5. mount point of a file system mounted by hand
Is there any chance that this, or the related snapinfo commit, fixes
PR 94635?
Ceri
--=20
That must be wonderful! I don't understand it at all.
-- Moliere
--UvwuEPigQXXfOf7G
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)
iD8DBQFF+nx8ocfcwTS3JF8RAvxwAJ9aASVui65UIpKrg0L9Rp/eVzlkKwCgim6Q
eW5zcRL2Yk2R/DNQumNpxzw=
=ZRw4
-----END PGP SIGNATURE-----
--UvwuEPigQXXfOf7G--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070316111612.GZ53780>