Date: Thu, 4 Jan 2018 00:38:16 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457878 - head/textproc/rubygem-liquid-tag-parser Message-ID: <CAMHz58S0Wc8TbDdkGfDNidhbTNanAfSe0usg0NAX%2BUS=U57DWg@mail.gmail.com> In-Reply-To: <c3ce68d6-2520-2aa6-0204-63161a4cffee@FreeBSD.org> References: <201801021533.w02FXYPG017753@repo.freebsd.org> <c3ce68d6-2520-2aa6-0204-63161a4cffee@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 2, 2018 at 11:54 PM, Mathieu Arnold <mat@freebsd.org> wrote: > Le 02/01/2018 =C3=A0 16:33, Sunpoet Po-Chuan Hsieh a =C3=A9crit : > > Author: sunpoet > > Date: Tue Jan 2 15:33:33 2018 > > New Revision: 457878 > > URL: https://svnweb.freebsd.org/changeset/ports/457878 > > > > Log: > > Fix build on Ruby prior to 2.5 > > > > Ruby 2.5 bundled RDoc 6.0.1. Due to unknown RDoc issue, RDoc prior to > > 6.0.0.beta1+ failed to parse the regex in lib/liquid/tag/parser.rb. > > Upstream also set "has_rdoc =3D false" in gemspec. > > > > Modified: > > head/textproc/rubygem-liquid-tag-parser/Makefile > > > > Modified: head/textproc/rubygem-liquid-tag-parser/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- head/textproc/rubygem-liquid-tag-parser/Makefile Tue Jan 2 > 15:33:28 2018 (r457877) > > +++ head/textproc/rubygem-liquid-tag-parser/Makefile Tue Jan 2 > 15:33:33 2018 (r457878) > > @@ -18,4 +18,6 @@ NO_ARCH=3D yes > > USE_RUBY=3D yes > > USES=3D gem > > > > +NOPORTDOCS=3D yes > > + > > > Setting NOPORTDOCS in a port was never supported, it is a deprecated > variable, set only in make.conf, please revert. If you need to disable > the DOCS option, either do not add it to OPTIONS_DEFINE, or add it to > OPTIONS_EXCLUDE. > > It's a temporary fix to avoid the rdoc issue. from Mk/Uses/gem.mk: .if ${PORT_OPTIONS:MDOCS} RUBYGEM_ARGS+=3D --rdoc --ri .else RUBYGEM_ARGS+=3D --no-rdoc --no-ri .endif I did think of OPTIONS_EXCLUDE but did not know it works 'cos it looks strange when there's no OPTIONS_DEFINE=3DDOCS. But anyway it really works. Thanks! > > -- > Mathieu Arnold > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58S0Wc8TbDdkGfDNidhbTNanAfSe0usg0NAX%2BUS=U57DWg>