Date: Wed, 12 Jan 2022 21:05:22 GMT From: Cy Schubert <cy@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 896a01531909 - main - ipfilter: Fixup comment Message-ID: <202201122105.20CL5MlX080099@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=896a0153190937e071a31c682c6cf55e4c599886 commit 896a0153190937e071a31c682c6cf55e4c599886 Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2022-01-12 21:03:46 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2022-01-12 21:03:46 +0000 ipfilter: Fixup comment Fix comment documenting checksum block in ip_nat.c. Fastforward doesn't perform checksum. MFC after: 1 week --- sys/netpfil/ipfilter/netinet/ip_nat.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/netpfil/ipfilter/netinet/ip_nat.c b/sys/netpfil/ipfilter/netinet/ip_nat.c index 1c63960e5139..8e9d555395ff 100644 --- a/sys/netpfil/ipfilter/netinet/ip_nat.c +++ b/sys/netpfil/ipfilter/netinet/ip_nat.c @@ -5021,10 +5021,8 @@ ipf_nat_out(fr_info_t *fin, nat_t *nat, int natadd, u_32_t nflags) defined(BRIDGE_IPF) || defined(__FreeBSD__) else { /* - * Strictly speaking, this isn't necessary on BSD - * kernels because they do checksum calculation after - * this code has run BUT if ipfilter is being used - * to do NAT as a bridge, that code doesn't exist. + * We always do this on FreeBSD because this code doesn't + * exist in fastforward. */ switch (nat->nat_dir) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202201122105.20CL5MlX080099>