Date: Mon, 18 Jun 2001 12:01:30 +0300 From: Peter Pentchev <roam@orbitel.bg> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/fstat fstat.c Message-ID: <20010618120130.G1713@ringworld.oblivion.bg> In-Reply-To: <20010618115221.D56404@sunbay.com>; from ru@FreeBSD.org on Mon, Jun 18, 2001 at 11:52:21AM %2B0300 References: <200106180629.f5I6TVs70841@freefall.freebsd.org> <20010618115221.D56404@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 18, 2001 at 11:52:21AM +0300, Ruslan Ermilov wrote: > On Sun, Jun 17, 2001 at 11:29:31PM -0700, Peter Pentchev wrote: > > roam 2001/06/17 23:29:31 PDT > > > > Modified files: > > usr.bin/fstat fstat.c > > Log: > > Teach fstat(1) about FIFO's - it's OK to display them as regular files. > > While I'm here, fix two second-level indents to be four spaces. > > > > Reviewed by: dd, -audit > > > > Revision Changes Path > > 1.32 +11 -4 src/usr.bin/fstat/fstat.c > > > FreeBSD Committer Guide, section 2: > > : Avoid committing style or whitespace fixes and functionality fixes in one > : go. It makes merging difficult, and also makes it harder to understand just > : what functional changes were made. OK, I know this, and I mentioned it in my second mail to -audit. <quote> And btw, no, I don't think it is worth it in this particular case to separate functionality and whitespace changes. Even the untrained eye can easily see that the first and third chunk are no-ops :) </quote> And as I acknowledged in a response to a comment by Sheldon, from now on, I'll pass all my patches for review through some other list in addition to -audit. BTW, do people feel that I should back this change out, and redo it in two separate commits? G'luck, Peter -- If I had finished this sentence, To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010618120130.G1713>