Date: Thu, 9 Dec 2004 16:46:07 -0500 From: Michael Johnson <ahze@ahze.net> To: Kris Kennaway <kris@obsecurity.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/math/fftw3 Makefile ports/math/fftw3/files patch-alloc.c Message-ID: <BB806AFE-4A2B-11D9-80E0-000A958C81C6@ahze.net> In-Reply-To: <20041209214821.GA89551@xor.obsecurity.org> References: <200412091921.iB9JL4F7081024@repoman.freebsd.org> <20041209212909.GA89159@xor.obsecurity.org> <E81CBD9D-4A29-11D9-80E0-000A958C81C6@ahze.net> <20041209214821.GA89551@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail-2--232484121
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII; format=flowed
On Dec 9, 2004, at 4:48 PM, Kris Kennaway wrote:
> On Thu, Dec 09, 2004 at 04:33:03PM -0500, Michael Johnson wrote:
>>
>> On Dec 9, 2004, at 4:29 PM, Kris Kennaway wrote:
>>
>>> On Thu, Dec 09, 2004 at 07:21:04PM +0000, Michael Johnson wrote:
>>>> ahze 2004-12-09 19:21:04 UTC
>>>>
>>>> FreeBSD ports repository
>>>>
>>>> Modified files:
>>>> math/fftw3 Makefile
>>>> math/fftw3/files patch-alloc.c
>>>> Log:
>>>> - Add note about WITH_OPTIMIZED_ATHLON will fall back to 3dNow if
>>>> you don't have
>>>> a Athlon
>>>
>>> Why not just use the CPU feature list from <bsd.cpu.mk>, so it
>>> automatically DTRT when CPUTYPE is set?
>>
>>
>> Should I do it like...
>>
>> .if ${CPUTYE}=="athlon" || ${CPUTYPE}=="athlon-xp" ||
>> ${CPUTYPE}=="k6-3" || ${CPUTYPE}=="k6-2" ... etc
>> ..code...
>> .endif
>>
>> ??
>
> No, see e.g. mpg123
ahh, thanks
Should I remove the OPTION and always use that if the cpu has 3dnow or
still give an option to do it?
>
> Kris
--Apple-Mail-2--232484121
content-type: application/pgp-signature; x-mac-type=70674453;
name=PGP.sig
content-description: This is a digitally signed message part
content-disposition: inline; filename=PGP.sig
content-transfer-encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
iD8DBQFBuMefn4uqfTwEb9YRAiekAJ46GTj0NpB1zrdAZCXpV9jrr9hwUgCePRYG
6ISa8TpxBgOemHRFm6iIcXg=
=DPM2
-----END PGP SIGNATURE-----
--Apple-Mail-2--232484121--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BB806AFE-4A2B-11D9-80E0-000A958C81C6>