Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jun 2007 11:07:13 -0500
From:      "Jeremy Messenger" <mezz7@cox.net>
To:        "Martin Wilke" <miwi@freebsd.org>
Cc:        infofarmer@freebsd.org, Dukashvili Guram <white_raven@users.berlios.de>, cvs-all@freebsd.org, ports-committers@freebsd.org, sat@freebsd.org, cvs-ports@freebsd.org
Subject:   Re: cvs commit: ports/net-mgmt Makefile ports/net-mgmt/macroscope Makefile distinfo pkg-descr pkg-plist ports/net-mgmt/macroscope/files macroscope.in
Message-ID:  <op.ttw5qbgt9aq2h7@mezz.mezzweb.com>
In-Reply-To: <20070614154947.B765750BBA@unixfreunde.net>
References:  <200706141532.l5EFWe4Y015940@repoman.freebsd.org> <20070614153245.16C1716A4D2@hub.freebsd.org> <cb5206420706140847w2c7dde1dm34a74475682e2ffa@mail.gmail.com> <20070614154947.B765750BBA@unixfreunde.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 14 Jun 2007 12:59:02 -0500, Martin Wilke <miwi@FreeBSD.org> wrot=
e:

> On Thu, 14 Jun 2007 19:47:34 +0400
> "Andrew Pantyukhin" <sat@FreeBSD.org> wrote:
>
> |On 6/14/07, Martin Wilke <miwi@freebsd.org> wrote:
> |> miwi        2007-06-14 15:32:40 UTC
> |>
> |>   FreeBSD ports repository
> |>
> |>   Modified files:
> |>     net-mgmt             Makefile
> |>   Added files:
> |>     net-mgmt/macroscope  Makefile distinfo pkg-descr pkg-plist
> |>     net-mgmt/macroscope/files macroscope.in
> |>   Log:
> |>   Macroscope is a squid, sendmail, courier, bpft log files analizer=
,
> |>     IP sniffer and HTML report generator.
> |>   Features:
> |>     squid log file parser.
> |>     sendmail log file parser.
> |>     courier log file parser.
> |>     bpft(ports/net-mgmt/bpft) log file parser.
> |>     Database backends support: MySQL, Firebird.
> |>     IP sniffer via pcap library (ports/net/libpcap).
> |>     Direct commit changes to database in realtime (no log files).
> |>     Traffic static HTML reports generating by date periods.
> |>     Traffic dynamic HTML reports generating via CGI (Web interface)=
.
> |>     Multithreading architecture.
> |>     Portable: BSD os'es and Windows NT family supported, but tested=

> |at this time >               only under FreeBSD 5.x 6.x amd64 i386 an=
d
> |Windows 2000 XP 2003. >
> |>   WWW: http://developer.berlios.de/projects/macroscope/
> |>
> |>   - Dukashvili Guram
> |>   white_raven@users.berlios.de
> |>
> |>   PR:             ports/112653
> |>   Submitted by:   Dukashvili Guram <white_raven at users.berlios.de=
>
> |>
> |>   Revision  Changes    Path
> |>   1.122     +1 -0      ports/net-mgmt/Makefile
> |>   1.1       +53 -0     ports/net-mgmt/macroscope/Makefile (new)
> |>   1.1       +3 -0      ports/net-mgmt/macroscope/distinfo (new)
> |>   1.1       +52 -0     ports/net-mgmt/macroscope/files/macroscope.i=
n
> |(new) >   1.1       +20 -0     ports/net-mgmt/macroscope/pkg-descr
> |(new) >   1.1       +8 -0      ports/net-mgmt/macroscope/pkg-plist
> |(new) > _______________________________________________
> |> +USE_BZIP2=3D     yes
> |> +USE_RC_SUBR=3D   macroscope
> |> +
> |> +BUILD_DEPENDS+=3D        cmake:${PORTSDIR}/devel/cmake
> |> +LIB_DEPENDS+=3D  lzo2:${PORTSDIR}/archivers/lzo2 \
> |> +               odbc:${PORTSDIR}/databases/unixODBC \
> |> +               pcap:${PORTSDIR}/net/libpcap
> |
> |Casual use of +=3D where it's clear the variable has
> |not been assigned yet is not encouraged.
> |
> |> +CMAKE_ARGS=3D    -DCMAKE_BUILD_TYPE:STRING=3DRelease \
> |> +               -DCMAKE_C_COMPILER:STRING=3D"${CC}" \
> |> +               -DCMAKE_C_FLAGS:STRING=3D"${CFLAGS}" \
> |> +               -DCMAKE_CXX_COMPILER:STRING=3D"${CXX}" \
> |> +               -DCMAKE_CXX_FLAGS:STRING=3D"${CXXFLAGS}" \
> |> +               -DCMAKE_INSTALL_PREFIX=3D${PREFIX}
> |> +
> |> +.include <bsd.port.pre.mk>
> |> +
> |> +.if defined(NOPORTDOCS)
> |> +CMAKE_ARGS+=3D   -DCMAKE_NOT_INSTALL_DOC:BOOL=3DON
> |> +.endif
> |> +
> |> +.if defined(WITHOUT_MYSQL)
> |> +USE_MYSQL=3D     yes
> |> +.endif
> |
> |This looks broken.

Yep.

> |> +.if defined(WITH_FIREBIRD)
> |> +LIB_DEPENDS+=3D  fbclient:${PORTSDIR}/databases/firebird-client
> |> +.endif
> |> +
> |> +do-configure:
> |> +       @(cd ${WRKSRC}; \
> |> +       ${LOCALBASE}/bin/cmake ${CMAKE_ARGS} .)
> |> +
> |> +.include <bsd.port.post.mk>
> |> Index: ports/net-mgmt/macroscope/distinfo
> |> diff -u /dev/null ports/net-mgmt/macroscope/distinfo:1.1
> |> --- /dev/null   Thu Jun 14 15:32:44 2007
> |> +++ ports/net-mgmt/macroscope/distinfo  Thu Jun 14 15:32:40 2007
> |> @@ -0,0 +1,3 @@
> |> +MD5 (macroscope-1.0.2108.tar.bz2) =3D b53a2775c402a0a64dbcd43abda1=
dec8
> |> +SHA256 (macroscope-1.0.2108.tar.bz2) =3D
> |62a8154e75709d0ad7955c8638301e3502e5a8023a2db43f211041138a210638 >
> |+SIZE (macroscope-1.0.2108.tar.bz2) =3D 1984504 > Index:
> |ports/net-mgmt/macroscope/files/macroscope.in > diff -u /dev/null
> |ports/net-mgmt/macroscope/files/macroscope.in:1.1 > --- /dev/null
> |Thu Jun 14 15:32:44 2007 > +++
> |ports/net-mgmt/macroscope/files/macroscope.in       Thu Jun 14
> |15:32:40 2007 > @@ -0,0 +1,52 @@ > +#!/bin/sh
> |> +#
> |> +# macroscope - start Macroscope daemon
> |> +#
> |> +# $FreeBSD$
> |> +#
> |> +# PROVIDE: macroscope
> |> +# REQUIRE: DAEMON
> |> +# KEYWORD: shutdown
> |> +
> |> +#
> |---------------------------------------------------------------------=
--------
> |> +# macroscope_enable=3D"NO"       # set to YES to enable macroscope=
 >
> |+# > +# # optional:
> |> +# macroscope_flags=3D""          # additional command line argumen=
ts
> |> +#
> |> +
> |> +. %%RC_SUBR%%
> |> +
> |> +name=3D"macroscope"
> |> +rcvar=3D$(set_rcvar)
> |> +
> |> +prefix=3D"%%PREFIX%%"
> |> +
> |> +start_precmd()
> |> +{
> |> +       return 0
> |> +}
> |> +
> |> +stop_postcmd()
> |> +{
> |> +       rm -f "$pidfile" || warn "Could not remove $pidfile."
> |> +}
> |> +
> |> +# pidfile
> |> +eval pidfile=3D\$${name}_pidfile
> |> +pidfile=3D${pidfile:-/var/run/${name}.pid}
> |> +echo ${pidfile}
> |> +
> |> +# command and arguments
> |> +command=3D"%%PREFIX%%/sbin/${name}"
> |> +
> |> +# run this first
> |> +start_precmd=3D"start_precmd"
> |> +# and this last
> |> +stop_postcmd=3D"stop_postcmd"
> |> +
> |> +load_rc_config ${name}
> |> +
> |> +command_args=3D"--sniffer --daemon --pid ${pidfile}"
> |> +
> |> +run_rc_command "$1"
> |> Index: ports/net-mgmt/macroscope/pkg-descr
> |> diff -u /dev/null ports/net-mgmt/macroscope/pkg-descr:1.1
> |> --- /dev/null   Thu Jun 14 15:32:44 2007
> |> +++ ports/net-mgmt/macroscope/pkg-descr Thu Jun 14 15:32:40 2007
> |> @@ -0,0 +1,20 @@
> |> +Macroscope is a squid, sendmail, courier, bpft log files analizer,=

> |> +  IP sniffer and HTML report generator.
> |> +Features:
> |> +  squid log file parser.
> |> +  sendmail log file parser.
> |> +  courier log file parser.
> |> +  bpft(ports/net-mgmt/bpft) log file parser.
> |> +  Database backends support: MySQL, Firebird.
> |> +  IP sniffer via pcap library (ports/net/libpcap).
> |> +  Direct commit changes to database in realtime (no log files).
> |> +  Traffic static HTML reports generating by date periods.
> |> +  Traffic dynamic HTML reports generating via CGI (Web interface).=

> |> +  Multithreading architecture.
> |> +  Portable: BSD os'es and Windows NT family supported, but tested
> |at this time > +            only under FreeBSD 5.x 6.x amd64 i386 and=

> |Windows 2000 XP 2003. > +
> |> +WWW: http://developer.berlios.de/projects/macroscope/
> |> +
> |> +- Dukashvili Guram
> |> +white_raven@users.berlios.de
> |> Index: ports/net-mgmt/macroscope/pkg-plist
> |> diff -u /dev/null ports/net-mgmt/macroscope/pkg-plist:1.1
> |> --- /dev/null   Thu Jun 14 15:32:44 2007
> |> +++ ports/net-mgmt/macroscope/pkg-plist Thu Jun 14 15:32:40 2007
> |> @@ -0,0 +1,8 @@
> |> +etc/macroscope.conf.template
> |> +sbin/macroscope
> |> +%%PORTDOCS%%%%DOCSDIR%%/AUTHORS
> |> +%%PORTDOCS%%%%DOCSDIR%%/INSTALL
> |> +%%PORTDOCS%%%%DOCSDIR%%/NEWS
> |> +%%PORTDOCS%%%%DOCSDIR%%/README
> |> +%%PORTDOCS%%%%DOCSDIR%%/mysql-user
> |> +%%PORTDOCS%%@dirrm %%DOCSDIR%%
> |
> |We have PORTDOCS Makefile variable for simple
> |cases like this one.
>
>
> BOAHRRRRRRRRRRRRR!!!!!!!!!!!!!
> Andrew, I am very tired of your accusations and I am (like many others=
)
> ignoring you from now on. If you have a problem with me take it
> streight to portsmgr@.

Uh? He actually is giving you a good feedback on your committed. He has =
 =

already pointed you a real broken lines above, so please correct it  =

instead ignoring him. Did you read submitter's patch when you took it  =

before you committed it?

Cheers,
Mezz

> PS: can you read the last freefall line
>>> Shut up and code!!!


-- =

mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team  -  FreeBSD Multimedia Hat (ports, not src)
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org
http://wiki.freebsd.org/multimedia  -  multimedia@FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.ttw5qbgt9aq2h7>