Date: Mon, 12 Jul 2010 12:09:42 -0700 From: Doug Barton <dougb@FreeBSD.org> To: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Fix typos in bsd.port.mk and minor logic improvements Message-ID: <4C3B6876.9000402@FreeBSD.org> In-Reply-To: <AANLkTimZIyoQfKGolPiOvzpBMuCQp4VqtBWaTNU3WVoP@mail.gmail.com> References: <AANLkTimZIyoQfKGolPiOvzpBMuCQp4VqtBWaTNU3WVoP@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/09/10 08:11, Garrett Cooper wrote:
> -# UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED!
> +# UNAUTHORIZED CHANGES WILL BE UNCONDITIONALLY REVERTED!
Couple of comments. The above is not a typo, that's the British
spelling. We generally don't change those. (Arguably it adds character
to the project.) :)
The other is more of a question, I'm not sure what the point of these
changes is: ${var:-} The :- parameter substitution kicks in if var is
unset or null, but you're not substituting it with anything.
Doug
--
... and that's just a little bit of history repeating.
-- Propellerheads
Improve the effectiveness of your Internet presence with
a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C3B6876.9000402>