Date: Wed, 6 Jul 2022 17:31:12 +0200 From: Matthias Fechner <mfechner@FreeBSD.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure Message-ID: <e3534f11-5199-d7a4-b651-02978dfb667c@FreeBSD.org> In-Reply-To: <CAMHz58SnxZExPOADE4NZFDvKJD=w-mtJ1vbvVJHDvXcVw7X_Vw@mail.gmail.com> References: <202206301432.25UEWIi4077084@gitrepo.freebsd.org> <CAMHz58SnxZExPOADE4NZFDvKJD=w-mtJ1vbvVJHDvXcVw7X_Vw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------0HxeuPcwScaUg30kIKNvwqj0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear Sunpoet, Am 06.07.2022 um 16:35 schrieb Po-Chuan Hsieh: > On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner > <mfechner@freebsd.org> wrote: > > The branch main has been updated by mfechner: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=4671249405c05bb65dfec261eb645081ea72fdf5 > <https://cgit.FreeBSD.org/ports/commit/?id=4671249405c05bb65dfec261eb645081ea72fdf5>; > > commit 4671249405c05bb65dfec261eb645081ea72fdf5 > Author: Matthias Fechner <mfechner@FreeBSD.org> > AuthorDate: 2022-06-30 14:28:33 +0000 > Commit: Matthias Fechner <mfechner@FreeBSD.org> > CommitDate: 2022-06-30 14:32:13 +0000 > > net/rubygem-omniauth-auth0: Fix build failure > > > Fixes a build regression after: > 56e085ca55a831ab56e2e6b417bf230c827fd2e5 > > > I think this commit is incorrect. > I could build this port successfully with rubygem-omniauth-oauth2 (1.8.0) > Please provide the error message. > > Furthermore, the only difference between omniauth-oauth2 1.7.3 and > 1.8.0 [1] is the change of omniauth from ">=1.9<3" to ">=2<3" > where security/rubygem-omniauth is 2.1.0 already. > I don't know how it can fix build failure. > > [1] https://github.com/omniauth/omniauth-oauth2/compare/v1.7.3...v1.8.0 And this change caused a race in the dependency tree. I suggest you build www/gitlab-ce, then you will see the error. Or you can also search here to find the correct log file: https://pkg.fechner.net/jail.html?mastername=131amd64-default Here the direct link to the log: https://pkg.fechner.net/build.html?mastername=131amd64-default&build=2022-06-30_10h05m29s Resolving dependencies... Bundler could not find compatible versions for gem "omniauth": In Gemfile: omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on omniauth (~> 1.0) omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on omniauth-oauth2 (~> 1.4) was resolved to 1.8.0, which depends on omniauth (~> 2.0) *** Error code 6 This modification was the minimal fix I figured out without the need to rollback a commit. > > > -RUN_DEPENDS= > rubygem-omniauth-oauth2>=1.1:net/rubygem-omniauth-oauth2 > > > That should be >=1.4<2 to match upstream (~> 1.4). > And net/rubygem-omniauth-oauth2 (1.8.0) fits the range. > > +RUN_DEPENDS= > rubygem-omniauth-oauth2-v1>=1.4<2:net/rubygem-omniauth-oauth2-v1 > yes and that is what I changed here. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook --------------0HxeuPcwScaUg30kIKNvwqj0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <div class="moz-cite-prefix">Dear Sunpoet,</div> <div class="moz-cite-prefix"><br> </div> <div class="moz-cite-prefix">Am 06.07.2022 um 16:35 schrieb Po-Chuan Hsieh:<br> </div> <blockquote type="cite" cite="mid:CAMHz58SnxZExPOADE4NZFDvKJD=w-mtJ1vbvVJHDvXcVw7X_Vw@mail.gmail.com"> <meta http-equiv="content-type" content="text/html; charset=UTF-8"> <div dir="ltr"> <div dir="ltr">On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner <<a href="mailto:mfechner@freebsd.org" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">mfechner@freebsd.org</a>> wrote:<br> </div> <div class="gmail_quote"> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by mfechner:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=4671249405c05bb65dfec261eb645081ea72fdf5" rel="noreferrer" target="_blank" moz-do-not-send="true">https://cgit.FreeBSD.org/ports/commit/?id=4671249405c05bb65dfec261eb645081ea72fdf5</a><br>; <br> commit 4671249405c05bb65dfec261eb645081ea72fdf5<br> Author: Matthias Fechner <a class="moz-txt-link-rfc2396E" href="mailto:mfechner@FreeBSD.org"><mfechner@FreeBSD.org></a><br> AuthorDate: 2022-06-30 14:28:33 +0000<br> Commit: Matthias Fechner <a class="moz-txt-link-rfc2396E" href="mailto:mfechner@FreeBSD.org"><mfechner@FreeBSD.org></a><br> CommitDate: 2022-06-30 14:32:13 +0000<br> <br> net/rubygem-omniauth-auth0: Fix build failure</blockquote> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> Fixes a build regression after:<br> 56e085ca55a831ab56e2e6b417bf230c827fd2e5<br> </blockquote> <div><br> </div> <div>I think this commit is incorrect.</div> <div>I could build this port successfully with rubygem-omniauth-oauth2 (1.8.0)</div> <div>Please provide the error message.</div> <div><br> </div> <div> <div>Furthermore, the only difference between omniauth-oauth2 1.7.3 and 1.8.0 [1] is the change of omniauth from ">=1.9<3" to ">=2<3" where security/rubygem-omniauth is 2.1.0 already.</div> <div>I don't know how it can fix build failure.</div> <div><br> </div> <div>[1] <a href="https://github.com/omniauth/omniauth-oauth2/compare/v1.7.3...v1.8.0" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/omniauth/omniauth-oauth2/compare/v1.7.3...v1.8.0</a></div>; </div> </div> </div> </blockquote> <p>And this change caused a race in the dependency tree.<br> </p> <p>I suggest you build www/gitlab-ce, then you will see the error.<br> Or you can also search here to find the correct log file:<br> <a class="moz-txt-link-freetext" href="https://pkg.fechner.net/jail.html?mastername=131amd64-default">https://pkg.fechner.net/jail.html?mastername=131amd64-default</a></p>; <p>Here the direct link to the log:<br> <a class="moz-txt-link-freetext" href="https://pkg.fechner.net/build.html?mastername=131amd64-default&build=2022-06-30_10h05m29s">https://pkg.fechner.net/build.html?mastername=131amd64-default&build=2022-06-30_10h05m29s</a></p>; <pre>Resolving dependencies... Bundler could not find compatible versions for gem "omniauth": In Gemfile: omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on omniauth (~> 1.0) omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on omniauth-oauth2 (~> 1.4) was resolved to 1.8.0, which depends on omniauth (~> 2.0) *** Error code 6</pre> <p>This modification was the minimal fix I figured out without the need to rollback a commit.<br> </p> <blockquote type="cite" cite="mid:CAMHz58SnxZExPOADE4NZFDvKJD=w-mtJ1vbvVJHDvXcVw7X_Vw@mail.gmail.com"> <div dir="ltr"> <div class="gmail_quote"> <div><br> </div> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> -RUN_DEPENDS= rubygem-omniauth-oauth2>=1.1:net/rubygem-omniauth-oauth2<br> </blockquote> <div><br> </div> <div>That should be >=1.4<2 to match upstream (~> 1.4).</div> <div>And net/rubygem-omniauth-oauth2 (1.8.0) fits the range.</div> <div><br> </div> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> +RUN_DEPENDS= rubygem-omniauth-oauth2-v1>=1.4<2:net/rubygem-omniauth-oauth2-v1<br> <br> </blockquote> </div> </div> </blockquote> <p>yes and that is what I changed here.<br> </p> <p><br> </p> <pre class="moz-signature" cols="72"> Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook </pre> </body> </html> --------------0HxeuPcwScaUg30kIKNvwqj0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e3534f11-5199-d7a4-b651-02978dfb667c>