Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Nov 2024 12:26:29 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 282832] makefs zfs creates images with the same guid
Message-ID:  <bug-282832-227-1M5Z7Vzdvn@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-282832-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-282832-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282832

--- Comment #1 from Pat Maddox <pat@patmaddox.com> ---
I see there is a comment [1] about using a fixed seed:

        /*
         * Use a fixed seed to provide reproducible pseudo-random numbers f=
or
         * on-disk structures when needed (e.g., GUIDs, ZAP hash salts).
         */

When are these needed to be reproducible?

Should makefs take another flag to produce random GUIDs, or have a note in =
the
man page that it will always produce the same GUID? I spent quite a bit of =
time
trying to load two images into bhyve before realizing it was a guid conflic=
t.

I don't think it should be necessary to import the zpool and reguid it, so =
I'd
be in favor of a flag if there's some reason the default should always prod=
uce
the same GUID.

[1] https://cgit.freebsd.org/src/tree/usr.sbin/makefs/zfs.c#n787

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-282832-227-1M5Z7Vzdvn>