Date: Mon, 3 Sep 2001 11:36:58 +0930 From: Greg Lehey <grog@FreeBSD.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Matt Dillon <dillon@earth.backplane.com>, Peter Wemm <peter@wemm.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Yet another style(9) bogon (was: cvs commit: src/sys/kern subr_prof.c kern_ntptime.c kern_xxx.c) Message-ID: <20010903113657.L59668@wantadilla.lemis.com> In-Reply-To: <69327.999413477@critter>; from phk@critter.freebsd.dk on Sun, Sep 02, 2001 at 08:51:17AM %2B0200 References: <200109010827.f818RW370778@earth.backplane.com> <69327.999413477@critter>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, 2 September 2001 at 8:51:17 +0200, Poul-Henning Kamp wrote:
> In message <200109010827.f818RW370778@earth.backplane.com>, Matt Dillon writes:
>>
>>> static void
>>> usage()
>>> {
>>> /* Insert an empty line if the function has no local variables. */
>>
>> You must be joking. Who came up with that carp? A blank line if
>> the function has no local variables? In my entire life as a programmer
>> I have never once seen that style. It looked like a mistake. If I
>> see any more I won't take out the blank line but... no, I don't want to
>> know whos idea it was.
>
> Well, there must be a lot of the FreeBSD kernel you have never looked at.
Or noticed this particular wrinkle. Just because things look broken
doesn't mean that it has to be because of style(9).
> It's very convenient to know that the first blank line in a function
> means the end of local variables, it makes simple source-munging
> scripts much easier.
Hmm. And I thought that style(9) was supposed to make it easier for
humans to read the source, not for programs.
> Until such time as you negotiate a change in style(9) on this point,
> you are just as bound by it as any other committer.
I don't see any evidence that Matt wanted to ignore it; quite the
contrary, he said he would abide by it. I agree wholeheartedly that
it looks bloody silly.
Greg
--
See complete headers for address and phone numbers
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010903113657.L59668>