Date: Thu, 02 Apr 2009 01:56:58 -0500 From: Robert Noland <rnoland@FreeBSD.org> To: Kevin Oberman <oberman@es.net> Cc: freebsd-x11@FreeBSD.org Subject: Re: Xorg 7.4 crashes on exit Message-ID: <1238655418.20670.1.camel@balrog.2hip.net> In-Reply-To: <20090401160909.40BA81CC51@ptavv.es.net> References: <20090401160909.40BA81CC51@ptavv.es.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-YOZF+yw8QL0mkeTDwjGp
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Wed, 2009-04-01 at 09:09 -0700, Kevin Oberman wrote:
> > From: Robert Noland <rnoland@FreeBSD.org>
> > Date: Tue, 31 Mar 2009 11:49:07 -0500
> >=20
> > On Tue, 2009-03-31 at 09:36 -0700, Kevin Oberman wrote:
> > > > Date: Tue, 31 Mar 2009 16:16:57 +0100
> > > > From: "N.J. Mann" <njm@njm.me.uk>
> > > >=20
> > > > Hi Robert,
> > > >=20
> > > >=20
> > > > In message <1238445388.8491.358.camel@balrog.2hip.net>,
> > > > Robert Noland (rnoland@FreeBSD.org) wrote:
> > > > > On Mon, 2009-03-30 at 13:11 -0700, Kevin Oberman wrote:
> > > > > > > From: Robert Noland <rnoland@FreeBSD.org>
> > > > > > > Date: Mon, 30 Mar 2009 14:54:45 -0500
> > > > [snip]
> > > > > > >=20
> > > > > > > Is this on CURRENT or STABLE and do you know at least approxi=
mately when
> > > > > > > you started seeing the issue?
> > > > > > >=20
> > > > > >=20
> > > > > > It is on stable and I THINK it started when I updated my system=
to
> > > > > > 7.2-PRERELEASE last week. My previous Stable was on February 7 =
and it
> > > > > > pre-dated the Xorg-1.5.3 server update on the system.
> > > > > >=20
> > > > > > I normally update ports daily, but I did delay the Xorg update =
for a
> > > > > > week or two to let dust settle.
> > > > >=20
> > > > > There are a lot of changed in that window... I really hope that =
this
> > > > > doesn't fix it, but could you try reverting:
> > > > >=20
> > > > > balrog% svn diff -c r189669
> > > > > Index: drm_drv.c
> > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > > > --- drm_drv.c (revision 189668)
> > > > > +++ drm_drv.c (revision 189669)
> > > > > @@ -131,7 +131,7 @@
> > > > > .d_poll =3D drm_poll,
> > > > > .d_mmap =3D drm_mmap,
> > > > > .d_name =3D "drm",
> > > > > - .d_flags =3D D_TRACKCLOSE | D_NEEDGIANT
> > > > > + .d_flags =3D D_TRACKCLOSE
> > > > > };
> > > > > =20
> > > > > static struct drm_msi_blacklist_entry drm_msi_blacklist[] =3D {
> > > >=20
> > > > I was not sure whether you wanted Kevin, me or both of us to try th=
e
> > > > above, so I tried it anyway. :-) It has no visible affect here at =
all.
> > > > I double checked I had patched the right file and even re-compiled
> > > > (after doing a rm -rf /usr/obj and a make clean) and re-installed t=
he
> > > > resulting kernel. No change.
> > > >=20
> > > > Are there any debug messages I can enable to help you out here?
> > >=20
> > > For me and my Radeon, the change seems to have "fixed" the problem.=20
> > >=20
> > > I have rebooted several times, including after loading the system wit=
h a
> > > variety of graphics oriented tasks (Flash, MPEGs, WMV, ...), I have b=
een
> > > unable to trigger the problem with the NEEDGIANT. I don't have witnes=
s
> > > in my kernel and really would have problems with having it there on t=
his
> > > system this week as I am on-call. Yuck!
> >=20
> > Ok, could you try removing that and applying this attached change
> > instead:
> >=20
> > r190565 | rnoland | 2009-03-30 13:01:42 -0500 (Mon, 30 Mar 2009) | 5
> > lines
> >=20
> > We don't know what these pages are going to be used for, they should be
> > un-cached. This got lost somewhere with all the bus_dma fixups.
>=20
> Bingo! No more problems with shutting down X. No GIANT. I like this a LOT
> better.
>=20
> Thanks so much.
Ok, cool. That does give me an idea for the Intel issues as well
maybe...
> Heads up! Now that my ATi problem is resolved, I'll be hitting you with
> the problems I'm having with an nVidia 7800GT. I hope that the nVidia
> issue is "fixable" more readily, though, with config changes rather than
> patches.
I do have patches for nouveau drm. ;)
robert.
--=20
Robert Noland <rnoland@FreeBSD.org>
FreeBSD
--=-YOZF+yw8QL0mkeTDwjGp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)
iEYEABECAAYFAknUYboACgkQM4TrQ4qfROPd4QCdG3ejNaTzzFQqeGlgDu00+e+J
Jd0AniFZzwfi311mKgflLZcYkNHNLy8f
=JgUI
-----END PGP SIGNATURE-----
--=-YOZF+yw8QL0mkeTDwjGp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1238655418.20670.1.camel>