Date: Sat, 12 Jun 2004 15:10:14 -0700 (PDT) From: Doug White <dwhite@gumbysoft.com> To: Aragon Gouveia <aragon@phat.za.net> Cc: current@freebsd.org Subject: Re: kernel compile error, 5.2.1-RELEASE Message-ID: <20040612150955.O74026@carver.gumbysoft.com> In-Reply-To: <20040612133330.Y74026@carver.gumbysoft.com> References: <20040611152223.GA81299@phat.za.net> <20040612133330.Y74026@carver.gumbysoft.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Please try the attached patch and see if that makes the warning go away.
On Sat, 12 Jun 2004, Doug White wrote:
> On Fri, 11 Jun 2004, Aragon Gouveia wrote:
>
> > Just trying to get a kernel built on a 5.2.1-RELEASE box. Am encountering
> > this error:
> >
> > cc -c -O -pipe -march=pentiumpro -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=15000 -fno-strict-aliasing -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror /usr/src/sys/dev/fb/vga.c
> > /usr/src/sys/dev/fb/vga.c:1346: warning: `filll_io' defined but not used
> > /usr/src/sys/dev/fb/vga.c:1336: warning: `fill' defined but not used
>
> Do you have 'options VGA_NO_MODE_CHANGE' in your kernel config? If so,
> then I see that there are a couple of function defs in sys/dev/fb/vga.c
> that aren't removed by that option.
>
> I'll submit a patch to fix this.
>
>
--
Doug White | FreeBSD: The Power to Serve
dwhite@gumbysoft.com | www.FreeBSD.org
[-- Attachment #2 --]
--- vga.c.orig Sat Jun 12 13:51:48 2004
+++ vga.c Sat Jun 12 14:18:28 2004
@@ -471,7 +471,6 @@
static int probe_adapters(void);
static int set_line_length(video_adapter_t *adp, int pixel);
static int set_display_start(video_adapter_t *adp, int x, int y);
-static void filll_io(int val, vm_offset_t d, size_t size);
#ifndef VGA_NO_MODE_CHANGE
#ifdef VGA_WIDTH90
@@ -501,6 +500,7 @@
static void direct_fill_rect32(video_adapter_t *adp, int val, int x, int y,
int cx, int cy);
#endif /* notyet */
+static void filll_io(int val, vm_offset_t d, size_t size);
#endif /* !VGA_NO_MODE_CHANGE */
static void dump_buffer(u_char *buf, size_t len);
@@ -1330,6 +1330,7 @@
return 0;
}
+#ifndef VGA_NO_MODE_CHANGE
#if defined(__i386__) || defined(__amd64__) /* XXX */
static void
fill(int val, void *d, size_t size)
@@ -1349,7 +1350,7 @@
d += sizeof(u_int32_t);
}
}
-
+#endif /* VGA_NO_MODE_CHANGE */
/* entry points */
#if 0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040612150955.O74026>