Date: Fri, 9 Sep 2016 04:40:34 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Jason Helfman <jgh@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r421576 - in head/x11-wm/fluxbox: . files Message-ID: <20160909044034.GA62060@FreeBSD.org> In-Reply-To: <201609082007.u88K7Jhm001741@repo.freebsd.org> References: <201609082007.u88K7Jhm001741@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 08, 2016 at 08:07:19PM +0000, Jason Helfman wrote: > New Revision: 421576 > URL: https://svnweb.freebsd.org/changeset/ports/421576 > > [...] > -PORTDOCS= AUTHORS ChangeLog NEWS README TODO > +PORTDATA= * > +PORTDOCS= * > ... > -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_active.xpm > -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_pressed.xpm > -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_unfocus.xpm > -%%DATADIR%%/styles/BlueFlux/pixmaps/button_max_active.xpm > -%%DATADIR%%/styles/BlueFlux/pixmaps/button_max_pressed.xpm > ... Please don't do this. We should had never allowed globbed PORTDATA (it is less of an issue for PORTDOCS since they are usually less important and interesting). We have pkg-plist for a reason. It helps to track changes, assess them against the changelog, compare pkg-plists of different versions, etc. Previously I could see a new theme/style files in the commit diff and think, "hey, I should try that new version, wanna see it that theme looks nicer than my current one". Now it becomes harder. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160909044034.GA62060>