Date: Sun, 12 Jul 2026 01:17:54 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: dc6c193bb4a6 - main - loader.efi: Add xz decompression Message-ID: <o058303n-73q1-q19o-orn-r8p6947qn6p8@serrofq.bet> In-Reply-To: <CANCZdfq_kQQPhyG9CY%2BceJSjaqiBR6eb12hM52MCDRvQ0L_6Zw@mail.gmail.com> References: <6a5299d0.26e5e.70437550@gitrepo.freebsd.org> <nrpp8o-nr16-q7s0-5r17-rq268471n9@mnoonqbm.arg> <CANCZdfq_kQQPhyG9CY%2BceJSjaqiBR6eb12hM52MCDRvQ0L_6Zw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Sat, 11 Jul 2026, Warner Losh wrote: > On Sat, Jul 11, 2026 at 2:47 PM Bjoern A. Zeeb <bz@freebsd.org> wrote: > >> On Sat, 11 Jul 2026, Warner Losh wrote: >> >>> The branch main has been updated by imp: >>> >>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=dc6c193bb4a67e2e9ee97d1e3ac3e2950bd16979 >>> >>> commit dc6c193bb4a67e2e9ee97d1e3ac3e2950bd16979 >>> Author: Warner Losh <imp@FreeBSD.org> >>> AuthorDate: 2026-07-11 14:44:40 +0000 >>> Commit: Warner Losh <imp@FreeBSD.org> >>> CommitDate: 2026-07-11 19:28:47 +0000 >>> >>> loader.efi: Add xz decompression >>> >>> We can now decompress .xz compressed memory disks, like >>> FreeBSD-15.1-RELEASE-amd64-disc1.iso.xz >> >> Thank you! Helps me a lot! >> >> We need to make sure the .xz is correctly padded if needed: >> see 4bf34c597c44a2393ac5ec483e9cecac128d8202 >> > > Earlier versions of my xz stuff had an off by one error that would trigger > that warning. But I fixed that so we wouldn't lose the last byte. If there's > still a partial sector at the end, it should be truncated, no? I used to pass a foo.xz file in the past in as an md_image and the foo.xz wasn't properly padded as xz doesn't pad unlike gzip and bzip -- at least that was my understanding, so that file was corrupt when trying to read it. That's what triggered the above commit by kib. What I realize now is that we may now transparently uncompress the xz first and then pass the uncompressed version to md. Is there a way to prevent that? For an mfs_root I would love to have the transparent uncompressions but couldn't so far and that case should be fixed now and will defintiively save me cycles, but for a general purpose other "file" I many not want it to be decompressed just stay there as a read-only copy as-is. /bz -- Bjoern A. Zeeb r15:7home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?o058303n-73q1-q19o-orn-r8p6947qn6p8>