Date: Sun, 21 Mar 2004 11:11:33 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= <des@des.no> Cc: current@FreeBSD.org Subject: Re: Giant not owned in gbincore() Message-ID: <20040321110858.Y7398@gamplex.bde.org> In-Reply-To: <xzpr7vnkty0.fsf@dwp.des.no> References: <xzpr7vnkty0.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 20 Mar 2004, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote: > running America's Army 2.0.0a under ktrace results in the following > panic: > ... > exit1+0x47a > 0xc04920a6 is in exit1 (/usr/src/sys/kern/kern_exit.c:371). > 366=09=09tracecred =3D p->p_tracecred; > 367=09=09p->p_tracecred =3D NULL; > 368=09=09mtx_unlock(&ktrace_mtx); > 369=09=09PROC_UNLOCK(p); > 370=09=09if (tracevp !=3D NULL) > 371=09=09=09vrele(tracevp); > 372=09=09if (tracecred !=3D NULL) > 373=09=09=09crfree(tracecred); > 374=09#endif The above is not current. This was fixed in: % RCS file: /home/ncvs/src/sys/kern/kern_exit.c,v % Working file: kern_exit.c % head: 1.228 % ... % ---------------------------- % revision 1.228 % date: 2004/03/18 18:15:58; author: green; state: Exp; lines: +4 -1 % Add the missing Giant when doing anything with VFS -- in this case, % releasing the ktrace vnode. % ---------------------------- Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040321110858.Y7398>