Date: Sun, 26 Mar 2000 22:03:42 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: "C. Stephen Gunn" <csg@waterspout.com> Cc: archie@FreeBSD.ORG, rwatson@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet if_ether.c Message-ID: <200003270603.WAA36115@apollo.backplane.com> References: <200003231859.KAA01229@freefall.freebsd.org> <20000326024700.A3342@waterspout.com>
next in thread | previous in thread | raw e-mail | index | archive | help
:
:On Thu, Mar 23, 2000 at 10:59:00AM -0800, Matt Dillon wrote:
:
:> Fix parens in m_pullup() line in arp handling code. The code was
:> improperly doing the equivalent of (m = (function() == NULL)) instead
:> of ((m = function()) == NULL).
:>
:> This fixes a NULL pointer dereference panic with runt arp packets.
:
:While I understand this fix. I copied this check from the "recommended"
:procedure for calling m_pullup inside. There are several instances of
:missing parenthesis in sys/netgraph/*.c as well.
I don't see any problems with sys/netgraph/*.c ... if you think you
see an error please report the exact file(s) and line number(s).
:Can I ask how you ran across the problem? (IE how you got a NULL mbuf
:pointer queue for ARPINTR?) Or just general code review..
:
: - Steve
Wasn't me... was someone else, but I ran it to ground after examining
the assembly dump at the point of the panic.
I didn't actually notice the compile-time warning until after I tracked
down the assembly dump (the reason not being due to there being random
compile time warnings from -Wcast-qual obscuring the real one, but
instead because I always do a make -j 4 of the kernel and the stuff
flips through the window so quickly I usually don't notice the warnings).
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200003270603.WAA36115>