Date: Fri, 02 Feb 2007 19:37:55 +0100 From: Pav Lucistnik <pav@FreeBSD.org> To: Luigi Rizzo <rizzo@icir.org> Cc: cvs-ports@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/linux-kmod-compat Makefile distinfo pkg-descr pkg-plist Message-ID: <1170441475.33849.7.camel@ikaros.oook.cz> In-Reply-To: <20070202103221.C97555@xorpc.icir.org> References: <200702021808.l12I8KBY073193@repoman.freebsd.org> <1170440345.33849.0.camel@ikaros.oook.cz> <20070202103221.C97555@xorpc.icir.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
Luigi Rizzo píše v pá 02. 02. 2007 v 10:32 -0800:
> On Fri, Feb 02, 2007 at 07:19:05PM +0100, Pav Lucistnik wrote:
> > Luigi Rizzo píse v pá 02. 02. 2007 v 18:08 +0000:
> >
> > > + portlint also complains because the url in pkg-descr does not contain
> > > 'www'. Can't help it, the url really does not contain 'www'.
> >
> > It actually complains the URL is not prefixed with WWW: moniker.
> >
> > > + For the same reason, at this time i prefer not to list all individual
> > > files in pkg-plist. When the thing has settled a bit more, I will reconsider
> > > this choice.
> >
> > You can't do this. Now, the packages will contain nothing (read: be
> > useless).
>
> at least for the time being it makes no sense to have a
> package built for this port, for a variety of reasons
> (code stability, licensing, etc). So i have put in pkg-descr
> only enough info to cleanup on deinstall.
> I am not sure it will _ever_ make sense to have this as a package,
> when the code becomes stable enough it should should probably
> become part of the kernel.
>
> did i misunderstand something ?
Yes.
First, you break the Good Practices of port making.
Second, you deny your users a part of the general functionality of the
ports collection - ie. packages. Users will be unable to install binary
package from the network, users will be unable to build a package on
their machines and mass-install it on their other computers. You have no
rollback on upgrade, if it should fail.
Plus, you're setting a false impression that other people can get away
with this in their ports.
Now there are methods to have the pkg-plist autogenerated. How hard it
would be?
--
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
Two sausages are in a frying pan. One says, "Geez, it's hot in here isn't it?"
And the other one says, "Aaaaaah! A talking sausage!"
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)
iD8DBQBFw4UDntdYP8FOsoIRAt8gAJ45fnIgVb+7Pvt+EyMvP7Gte+XE6gCghWFo
XyREYKqv0LGMEyEy1GlHX2o=
=SGhg
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1170441475.33849.7.camel>