Date: Mon, 17 Jul 2023 11:11:54 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Konstantin Belousov <kostikbel@gmail.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 60381fd1ee86 - main - memdesc: Retire MEMDESC_CCB. Message-ID: <09687219-240b-c1a5-8e5a-956b231854d5@FreeBSD.org> In-Reply-To: <CANCZdfoFR7%2BZpcMTc1rnYDGc-KM98=a0-U0Zp_4eEqmzwSPemA@mail.gmail.com> References: <202307141841.36EIf3f0019403@gitrepo.freebsd.org> <ZLVizUl1Xyo1AQmy@kib.kiev.ua> <65d7d8d8-9f98-abd2-1ce3-ae3a2d3bf111@FreeBSD.org> <CANCZdfoHid=H1Ys_4XTJPfCaifevSoW92nGYXU3Ot=mTT13T%2Bg@mail.gmail.com> <ZLWARmA8XYh3wR6C@kib.kiev.ua> <CANCZdfpcbqgEV6Exuj-eGcr9yWuDHcdDvXfK4FZQVZCO8BwcjQ@mail.gmail.com> <92656b28-8bfa-23a9-2683-23ccb817b8a7@FreeBSD.org> <CANCZdfoFR7%2BZpcMTc1rnYDGc-KM98=a0-U0Zp_4eEqmzwSPemA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/17/23 11:07 AM, Warner Losh wrote: > On Mon, Jul 17, 2023 at 12:02 PM John Baldwin <jhb@freebsd.org> wrote: > >> On 7/17/23 10:58 AM, Warner Losh wrote: >>> On Mon, Jul 17, 2023 at 11:54 AM Konstantin Belousov < >> kostikbel@gmail.com> >>> wrote: >>> Or if it was in cam.h and made a static inline. It's short enough that >>> won't bloat >>> the kernel in the half a dozen places its called, and it would give >> similar >>> performance >>> to what we have today with the half a dozen nearly identical copies of >>> this routine. >>> And since it's all done with structure dancing, there's no other bits of >>> CAM that would >>> be brought into the kernel. >> >> I would be happy with an inline actually, I wasn't sure originally if that >> was >> too invasive in terms of the header bloat it would entail, in particular >> if it >> lived in sys/memdesc.h, but maybe it could live in cam_ccb.h? >> > > cam_ccb.h likely is fine, and logically it does belong there more than cam.h > now that you mention it... And only sys/kern/subr_bus_dma.c needs it, > since that's the only place that calls if my grep can be believed. I use it in my NVMeoF host, but that is also already including cam_ccb.h since it needs to know about CCB internals anyway. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?09687219-240b-c1a5-8e5a-956b231854d5>