Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Sep 2006 00:21:09 -0500 (CDT)
From:      Mike Silbersack <silby@silby.com>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/netinet in_pcb.c tcp_subr.c tcp_timer.c tcp_var.h
Message-ID:  <20060907001910.G12826@odysseus.silby.com>
In-Reply-To: <20060906151246.GU40020@FreeBSD.org>
References:  <200609061356.k86DuZ0w016069@repoman.freebsd.org> <20060906091204.B6691@odysseus.silby.com> <20060906143204.GQ40020@FreeBSD.org> <20060906093553.L6691@odysseus.silby.com> <20060906150129.GT40020@FreeBSD.org> <20060906151246.GU40020@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Wed, 6 Sep 2006, Gleb Smirnoff wrote:

> Another simple enough solution would be to msleep() with tcbinfo mutex
> temporarily dropped if we fail to find a port. Then the tcp_timer_2msl_tw()
> on the next run will free tcptw entries and wake up us.

Nah, not worth the effort.  time_wait sockets are good to try to follow 
the rules on, but if the choice is to delay or throw away one prematurely, 
throwing one away prematurely is the better choice.

> Anyway, I'm strongly against doing the purge cycling in the syscalls.

Yep, me too - doing purge cycling was never my intent; it was just 
supposed to be a last ditch attempt to free a time_wait socket that was 
taking up an ephemeral port when no ephemeral ports were left.

Mike "Silby" Silbersack



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060907001910.G12826>